Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error better when provider not set #336

Merged
merged 1 commit into from Apr 7, 2020
Merged

Error better when provider not set #336

merged 1 commit into from Apr 7, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Mar 2, 2020

I'm not sure if this was intentionally removed in v2, but we've seen a few users confused by the NullReferenceException.

Fixes #324

cc @ajcvickers

@ericsink
Copy link
Owner

ericsink commented Mar 3, 2020

Yes, I took this out on purpose, but for (what in hindsight is) a poor reason.

I'll put this (or something equivalent to it) back, but fair warning, I might not do so by simply accepting this PR.

Furthermore, I hereby acknowledge that my to-do list on SQLitePCLRaw has grown a bit lengthy, I need to devote a few days soon to catching up on everything.

@bricelam
Copy link
Contributor Author

bricelam commented Mar 3, 2020

lol, I was going to do it a lot simpler, but decided to use the previous code.

My first implementation:

private static ISqliteProvider __imp;
private static ISqliteProvider _imp => __imp ?? throw Exception(GRIPE);

@ericsink
Copy link
Owner

ericsink commented Mar 3, 2020

Now that's rather short and sweet...

@ericsink ericsink merged commit c7e2eed into ericsink:master Apr 7, 2020
@ericsink ericsink mentioned this pull request Apr 7, 2020
@bricelam bricelam deleted the bait branch April 7, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite3_open_v2 broken (Unity3D)
2 participants