Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nfpm_package produces symlinks in the rpm instead of packaging the file. #4

Open
leungster opened this issue May 24, 2023 · 0 comments

Comments

@leungster
Copy link

When we specify contents using bazel references, the resulting rpm has the symlink instead of the actual file.

contents:
  - src: "{{ index .Dependencies `@//cmd/rpm:binary}}"
    dst: "/bin/binary"

Starting with nfpm v2.13.0, symlinks are preserved instead of being evaluated. See PR goreleaser/nfpm#453

When nfpm_package is used, the bazel-out paths are symlinks back to the execroot. Since those links aren't evaluated, nfpm copies the symlinks as is.

I think the change is to evaluate the symlink here so that the bazel file output is directly referenced by nfpm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant