This repository has been archived by the owner on Jan 4, 2022. It is now read-only.
Enhancement: Implement DataProvider\ResourceProvider #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/resource-provider
branch
from
a424f3e
to
9dccc61
Compare
Codecov Report
@@ Coverage Diff @@
## main #344 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 84 85 +1
===========================================
Files 11 12 +1
Lines 285 288 +3
===========================================
+ Hits 285 288 +3
Continue to review full report at Codecov.
|
localheinz
commented
Oct 5, 2020
| public static function resource(): \Generator | ||
| { | ||
| yield from self::provideDataForValues([ | ||
| 'resource' => \fopen(__FILE__, 'rb'), |
There was a problem hiding this comment.
This might result in fatal errors when too many files are open, but we can fix it when it does.
ergebnis-bot
approved these changes
Oct 5, 2020
ergebnis-bot
approved these changes
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
DataProvider\ResourceProviderFollows #326.