Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Synchronize with ergebnis/php-library-template #262

Merged
merged 1 commit into from
Aug 29, 2020

Conversation

localheinz
Copy link
Member

This PR

@localheinz localheinz self-assigned this Aug 29, 2020
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #262 into main will increase coverage by 6.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #262      +/-   ##
============================================
+ Coverage     83.95%   90.20%   +6.25%     
  Complexity      150      150              
============================================
  Files            23       23              
  Lines           486      429      -57     
============================================
- Hits            408      387      -21     
+ Misses           78       42      -36     
Impacted Files Coverage Δ Complexity Δ
...ds/NoParameterWithContainerTypeDeclarationRule.php 94.00% <0.00%> (+3.09%) 14.00% <0.00%> (ø%)
...asses/PHPUnit/Framework/TestCaseWithSuffixRule.php 82.14% <0.00%> (+4.72%) 11.00% <0.00%> (ø%)
...rc/Methods/NoParameterWithNullDefaultValueRule.php 93.54% <0.00%> (+4.97%) 7.00% <0.00%> (ø%)
...ods/NoParameterWithNullableTypeDeclarationRule.php 93.10% <0.00%> (+5.22%) 6.00% <0.00%> (ø%)
src/Classes/FinalRule.php 94.11% <0.00%> (+5.22%) 17.00% <0.00%> (ø%)
...ods/NoConstructorParameterWithDefaultValueRule.php 92.85% <0.00%> (+5.35%) 7.00% <0.00%> (ø%)
src/Classes/NoExtendsRule.php 90.90% <0.00%> (+6.29%) 7.00% <0.00%> (ø%)
src/Methods/FinalInAbstractClassRule.php 86.36% <0.00%> (+6.36%) 9.00% <0.00%> (ø%)
src/Methods/PrivateInFinalClassRule.php 90.90% <0.00%> (+6.90%) 9.00% <0.00%> (ø%)
.../Functions/NoParameterWithNullDefaultValueRule.php 90.47% <0.00%> (+7.14%) 6.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a10c6f...0d708b2. Read the comment docs.

@ergebnis-bot ergebnis-bot merged commit 87571fc into main Aug 29, 2020
@ergebnis-bot ergebnis-bot deleted the feature/synchronize branch August 29, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants