Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bring back support for PHP 7.1 #166

Merged
merged 1 commit into from Dec 19, 2019
Merged

Fix: Bring back support for PHP 7.1 #166

merged 1 commit into from Dec 19, 2019

Conversation

localheinz
Copy link
Member

This PR

  • brings back support for PHP 7.1

Related to ergebnis/composer-normalize#266.

@localheinz localheinz added the bug label Dec 19, 2019
@localheinz localheinz self-assigned this Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #166 into master will decrease coverage by 6.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
- Coverage     90.63%   84.18%   -6.45%     
  Complexity      135      135              
============================================
  Files            22       22              
  Lines           395      449      +54     
============================================
+ Hits            358      378      +20     
- Misses           37       71      +34
Impacted Files Coverage Δ Complexity Δ
...c/Closures/NoNullableReturnTypeDeclarationRule.php 63.63% <0%> (-14.15%) 4% <0%> (ø)
src/Expressions/NoCompactRule.php 61.53% <0%> (-11.19%) 5% <0%> (ø)
.../Functions/NoNullableReturnTypeDeclarationRule.php 69.23% <0%> (-10.77%) 5% <0%> (ø)
src/Files/DeclareStrictTypesRule.php 78.94% <0%> (-9.29%) 9% <0%> (ø)
...res/NoParameterWithNullableTypeDeclarationRule.php 80% <0%> (-8.24%) 5% <0%> (ø)
...c/Closures/NoParameterWithNullDefaultValueRule.php 81.81% <0%> (-7.66%) 6% <0%> (ø)
...ons/NoParameterWithNullableTypeDeclarationRule.php 81.81% <0%> (-7.66%) 5% <0%> (ø)
...rc/Methods/NoNullableReturnTypeDeclarationRule.php 80% <0%> (-7.5%) 5% <0%> (ø)
.../Functions/NoParameterWithNullDefaultValueRule.php 83.33% <0%> (-7.15%) 6% <0%> (ø)
src/Methods/PrivateInFinalClassRule.php 84% <0%> (-6.91%) 9% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed2f1c...fc47645. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant