Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort allow-plugins and preferred-install properly #723

Merged

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Jul 24, 2022

This pull request

  • Fixes the sort-order for keys where wildcards are allowed and their order matters

The Composer documentation says that more specific keys should be listed first, which this change ensures while also keeping the items in alphabetical order.

Fixes ergebnis/composer-normalize#860
Fixes ergebnis/composer-normalize#868
Related to #590
Fixes ergebnis/composer-normalize#644
Related to #425

@fredden fredden marked this pull request as ready for review July 24, 2022 17:41
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #723 (ca7cf84) into main (f3eabe8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ca7cf84 differs from pull request most recent head 1fb20a0. Consider uploading reports for the commit 1fb20a0 to get more accurate results

@@            Coverage Diff            @@
##               main     #723   +/-   ##
=========================================
  Coverage     98.88%   98.88%           
+ Complexity      146      145    -1     
=========================================
  Files            32       32           
  Lines           449      450    +1     
=========================================
+ Hits            444      445    +1     
  Misses            5        5           
Impacted Files Coverage Δ
src/Vendor/Composer/ConfigHashNormalizer.php 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@localheinz localheinz self-assigned this Aug 10, 2022
@localheinz localheinz added the bug label Aug 10, 2022
@localheinz localheinz changed the title Sort allow-plugins and preferred-install properly Sort allow-plugins and preferred-install properly Aug 10, 2022
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz merged commit 1c3be30 into ergebnis:main Aug 10, 2022
@localheinz
Copy link
Member

Thank you, @fredden!

@fredden fredden deleted the sort-allow-plugins-preferred-install branch August 10, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants