Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Drop support for PHP 7.4 #998

Merged
merged 1 commit into from Dec 1, 2022
Merged

Fix: Drop support for PHP 7.4 #998

merged 1 commit into from Dec 1, 2022

Conversation

localheinz
Copy link
Member

This pull request

  • drops support for PHP 7.4

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #998 (0c69d72) into main (58e3418) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 0c69d72 differs from pull request most recent head c92ad68. Consider uploading reports for the commit c92ad68 to get more accurate results

@@             Coverage Diff              @@
##               main     #998      +/-   ##
============================================
+ Coverage     88.46%   88.52%   +0.06%     
  Complexity       55       55              
============================================
  Files             4        4              
  Lines           182      183       +1     
============================================
+ Hits            161      162       +1     
  Misses           21       21              
Impacted Files Coverage Δ
src/Command/NormalizeCommand.php 89.09% <0.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz merged commit d12fdec into main Dec 1, 2022
@localheinz localheinz deleted the fix/php7.4 branch December 1, 2022 11:11
jrfnl added a commit to jrfnl/composer-install that referenced this pull request Dec 11, 2022
Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`.

Refs:
* https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0
* ergebnis/composer-normalize#998
jrfnl added a commit to jrfnl/composer-install that referenced this pull request Dec 20, 2022
Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`.

Refs:
* https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0
* ergebnis/composer-normalize#998
ramsey pushed a commit to ramsey/composer-install that referenced this pull request Jan 2, 2023
* GH Actions: selectively use `fail-fast` with setup-php

I've seen some recent build failures due to the `setup-php` action running into a rate limit and not downloading the required version of Composer. In the case of this action, that would make the test runs worthless.

The `setup-php` action runner defaults to _showing_ these type errors in the logs, but not stopping the workflow run.

So, specifically for those jobs where the Composer version is important, I'm adding the `fail-fast` option to `setup-php` to fail the build if the action runner ran into any errors.

Ref: https://github.com/shivammathur/setup-php#fail-fast-optional

* GH Actions: update PHP version for `composer-normalize`

Looks like the `composer-normalize` package has dropped support for PHP < 8.0 as of version `2.29.0`.

Refs:
* https://github.com/ergebnis/composer-normalize/releases/tag/2.29.0
* ergebnis/composer-normalize#998

Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants