Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use Php74 rule set #853

Merged
merged 3 commits into from Dec 28, 2021
Merged

Enhancement: Use Php74 rule set #853

merged 3 commits into from Dec 28, 2021

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 28, 2021

This pull request

  • uses the Php74 rule set
  • runs make coding-standards
  • initializes properties in the constructor of a class

@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #853 (735e059) into main (c57a9ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #853   +/-   ##
=========================================
  Coverage     87.81%   87.81%           
  Complexity       57       57           
=========================================
  Files             4        4           
  Lines           279      279           
=========================================
  Hits            245      245           
  Misses           34       34           
Impacted Files Coverage Δ
src/Version.php 64.28% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57a9ce...735e059. Read the comment docs.

@localheinz localheinz merged commit 8f9711e into main Dec 28, 2021
@localheinz localheinz deleted the feature/php74 branch December 28, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants