Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New allow-plugins failed on GitHub actions #832

Closed
afbora opened this issue Dec 22, 2021 · 2 comments
Closed

New allow-plugins failed on GitHub actions #832

afbora opened this issue Dec 22, 2021 · 2 comments
Assignees
Labels

Comments

@afbora
Copy link

afbora commented Dec 22, 2021

Steps required to reproduce the problem

GitHub action failed when new allow-plugins feature used.

composer.json

"config": {
  "optimize-autoloader": true,
  "platform-check": false,
  "allow-plugins": {
    "getkirby/composer-installer": true
  }
},

Running ergebnis/composer-normalize 2.18.0 by Andreas Möller and contributors.
./composer.json is not normalized.

Related GitHub Action:
https://github.com/getkirby/kirby/runs/4607152066?check_suite_focus=true

Related articles:
https://blog.packagist.com/composer-2-2/

https://getcomposer.org/doc/06-config.md#allow-plugins

@localheinz
Copy link
Member

localheinz commented Dec 22, 2021

@afbora

From what I can see in https://github.com/getkirby/kirby/runs/4607152066?check_suite_focus=true, it looks like ergebnis/composer-normalize works fine. The issue I can see there is that after the update of ergebnis/composer-normalize, your composer.json is not normalized anymore (see #779).

Can you take a look at getkirby/kirby#4067?

Perhaps it's best not to update all dependencies at once, what do you think?

@afbora
Copy link
Author

afbora commented Dec 22, 2021

Fixed with version update and composer normalize. Thank you.

@afbora afbora closed this as completed Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants