Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove SchemaUriResolver and check in schema.json instead #273

Merged
merged 1 commit into from Dec 18, 2019

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Dec 18, 2019

This PR

  • removes the SchemaUriResolver and checks in schema.json instead

Fixes #254.
Replaces #255.

馃拋鈥嶁檪 This picks up the original idea of @drupol (see #170) to check in the schema - I believe this is the best approach for now. In the meanwhile I can sort something out using GitHub actions to keep schema.json updated.

@localheinz localheinz added the bug label Dec 18, 2019
@localheinz localheinz self-assigned this Dec 18, 2019
@localheinz localheinz merged commit f7d9795 into master Dec 18, 2019
@localheinz localheinz deleted the fix/schema branch December 18, 2019 17:41
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #273 into master will increase coverage by 7.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
+ Coverage        80%   87.03%   +7.03%     
+ Complexity       39       35       -4     
============================================
  Files             3        2       -1     
  Lines           175      162      -13     
============================================
+ Hits            140      141       +1     
+ Misses           35       21      -14
Impacted Files Coverage 螖 Complexity 螖
src/NormalizePlugin.php 72.72% <100%> (+2.72%) 3 <0> (酶) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 91c456e...9dff09b. Read the comment docs.

@drupol
Copy link

drupol commented Dec 18, 2019

Great :-)

This was referenced Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong schema file path
2 participants