Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transmit_data from the Transmitter #2005

Closed
sondreso opened this issue Sep 6, 2021 · 2 comments · Fixed by #2010
Closed

Remove transmit_data from the Transmitter #2005

sondreso opened this issue Sep 6, 2021 · 2 comments · Fixed by #2010
Assignees

Comments

@sondreso
Copy link
Collaborator

sondreso commented Sep 6, 2021

Also, do some research to see if the pydantic pickling issue is solved and released.

@jondequinor
Copy link
Contributor

cloudpipe/cloudpickle#403 is the pydantic+cloudpickle issue

@sondreso
Copy link
Collaborator Author

sondreso commented Sep 8, 2021

I have looked into the cloudpickle issue, and I cannot reproduce this with cloudpickle 1.6.0 and pydantic 1.8.2 (everything on Python 3.6). However, I can verify that the change in https://github.com/cloudpipe/cloudpickle/pull/409/files is not included and that the tests introduced in that PR still fails. So my best guess is that something changed in Pydantic, such that this is no longer an issue. We also have tests that should capture this if it ever appears again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants