Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continueOnMissingPermissions should continue when repoToken is missing? #107

Open
fgdorais opened this issue Aug 22, 2023 · 1 comment
Open

Comments

@fgdorais
Copy link

Perhaps continueOnMissingPermissions should continue when repoToken is missing?

The end purpose is to prevent this action from running on forks since that doesn't make sense in many use cases. Setting continueOnMissingPermissions does this and allows for exceptions where necessary permissions can be granted.

However, when the main repo uses MY_SPECIAL_TOKEN instead of something that exists in every repo, then the failure is missing input not missing permissions. I think continueOnMissingPermissions should handle this as if it were missing permissions and fail gracefully. The permissions are evidently missing in that case too!

@eps1lon
Copy link
Owner

eps1lon commented Mar 23, 2024

It used to be that forks only get a read-only token. Is that no longer the case?

If forks still get a read-only token, a missing token would be a misconfiguration that we should catch with an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants