NPM: 6.9.0 AJV Commit causing failure to execute node_modules (multiple dependencies affected i.e. ESLint and WebPack Loaders) #941

caldempsey · 2019-02-09T22:53:42Z

What version of Ajv are you using? Does the issue happen if you use the latest version?

Latest version (6.9.0 release I believe)

Ajv options object

node_modules/ajv/lib/keyword.js:65
      throw new Error('custom keyword definition is invalid: '  + this.errorsText(validateDefinition.errors));
      ^

Error: custom keyword definition is invalid: data.errors should be boolean
    at Ajv.addKeyword (/home/mmacheerpuppy/git/fsa/react-application/node_modules/ajv/lib/keyword.js:65:13)
    at module.exports (/home/mmacheerpuppy/git/fsa/react-application/node_modules/ajv-errors/index.js:10:7)
    at Object.<anonymous> (/home/mmacheerpuppy/git/fsa/react-application/node_modules/schema-utils/src/validateOptions.js:22:1)
    at Module._compile (module.js:652:30)
    at Object.Module._extensions..js (module.js:663:10)
    at Module.load (module.js:565:32)
    at tryModuleLoad (module.js:505:12)
    at Function.Module._load (module.js:497:3)
    at Module.require (module.js:596:17)
    at require (internal/module.js:11:18)

What results did you expect?

Expected to be able to build node_modules but experiencing above stacktrace.

Are you going to resolve the issue?
Current workaround is to remove ESLint dependencies for NPM users, or if using YARN to resolve dependencies to forced version. It's also possible (with the addition of another dependency) to use NPM resolutions (see conversation).

Reproduction

Try using the following packages declaration. npm post install will fail to start. ESLint relies on AJV.

{
  "name": "food-standards",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    
    "axios": "^0.18.0",
    "bootstrap": "^4.2.1",
    "react": "^16.8.1",
    "react-dom": "^16.8.1",
    "react-scripts": "2.1.3",
    "reactstrap": "^7.1.0"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": [
    ">0.2%",
    "not dead",
    "not ie <= 11",
    "not op_mini all"
  ],
  "devDependencies": {
    "axios-mock-adapter": "^1.16.0",
    "eslint": "5.6.0",
    "eslint-config-airbnb": "^17.1.0",
    "eslint-plugin-import": "^2.14.0",
    "eslint-plugin-jsx-a11y": "^6.1.1",
    "eslint-plugin-react": "^7.11.0",
    "react-testing-library": "^5.5.3"
  }
}

The text was updated successfully, but these errors were encountered:

yooouuri · 2019-02-09T22:56:26Z

Same error for me #942 here using vue.js

caldempsey · 2019-02-09T22:57:51Z

Is there a workaround to use an earlier release?

yooouuri · 2019-02-09T23:01:42Z

I hope it get noticed fast

tetreault · 2019-02-09T23:02:13Z

Using nuxt for vue. My solve is doing npm i -d ajv@5.0.0 and i can run npm run dev again. This was a fresh nuxt project I started.

caldempsey · 2019-02-09T23:05:05Z

This is certainly related to the latest changes made in the commit history.

yooouuri · 2019-02-09T23:05:56Z

Add

  "resolutions": {
    "ajv": "6.8.1"
  }

to your package.json will create a work around (I am using yarn, don't know if it will work for npm)

mcrawshaw · 2019-02-09T23:06:14Z

@epoberezkin can we roll back?

velocity-360 · 2019-02-09T23:11:12Z

Can confirm, this is happening for me too when scaffolding Vue JS projects. Currently on Vue CLI 3.4.0, Mac OS 10.13.4. Please fix soon as this is causing serious delays.

yooouuri · 2019-02-09T23:13:08Z

@velocity-360 see my comment, use the work around! 😄

csvan · 2019-02-09T23:13:09Z

Seeing the same thing when using latest storybook 4.1, reproducible by simply running the bin build-storybook included in the same package. This entirely breaks a very large ecosystem.

Error: custom keyword definition is invalid: data/errors should be boolean
    at Ajv.addKeyword (/home/csvan/IdeaProjects/pros-ui-components/module/node_modules/ajv/lib/keyword.js:66:13)
    at module.exports (/home/csvan/IdeaProjects/pros-ui-components/module/node_modules/ajv-errors/index.js:10:7)
    at Object.<anonymous> (/home/csvan/IdeaProjects/pros-ui-components/module/node_modules/schema-utils/src/validateOptions.js:22:1)
    at Module._compile (internal/modules/cjs/loader.js:734:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:745:10)
    at Module.load (internal/modules/cjs/loader.js:626:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:566:12)
    at Function.Module._load (internal/modules/cjs/loader.js:558:3)
    at Module.require (internal/modules/cjs/loader.js:663:17)
    at require (internal/modules/cjs/helpers.js:20:18)

velocity-360 · 2019-02-09T23:14:34Z

@velocity-360 see my comment, use the work around! 😄

@yooouuri thank you however, I am currently contracted to create a Vue tutorial series for a large educational software company and do not think it would be wise to kick off the series with a work-around immediately on the first step. I will wait for resolution.

yooouuri · 2019-02-09T23:15:01Z

@velocity-360 makes sense

caldempsey · 2019-02-09T23:15:09Z

@velocity-360 I'm trying to write a technical test for a job interview in React! 🤣

richard-karp · 2019-02-09T23:16:44Z

lol @mmacheerpuppy exact same situation for me

caldempsey · 2019-02-09T23:18:08Z

@RickyTony I spent some time debugging and it seems like latest AJV is a dependency for ESLint which may produce a collision. You can use npm ls ajv to check this out.

viankakrisna · 2019-02-09T23:18:28Z

workaround for yarn users:
add

  "resolutions": {
    "ajv": "6.5.5"
  }

to your package.json and re run yarn install

viankakrisna · 2019-02-09T23:19:03Z

looks like #941 (comment) beat me to that 😅

richard-karp · 2019-02-09T23:19:23Z

@mmacheerpuppy I kinda ran out of time for the day debugging, so hopefully it's fixed when I get back to it tomorrow

gregoriB · 2019-02-09T23:20:38Z

  "dependencies": {
    "react": "^16.8.1",
    "react-dom": "^16.8.1",
    "react-scripts": "2.1.3",
    "ajv": "6.8.1"
  }

this worked for me using npm

andrewtet · 2019-02-09T23:23:56Z

@gregoriB I'm using create-react-app and unfortunately, I'm still getting the error after adding that 😞

viankakrisna · 2019-02-09T23:25:26Z

https://stackoverflow.com/questions/52416312/npm-equivalent-of-yarn-resolutions

caldempsey · 2019-02-09T23:25:40Z

@sky-coding You say that as if we don't have dependency chains on the back-end! @andrewtet can you kindly show your package.json?

gregoriB · 2019-02-09T23:26:19Z

@andrewtet did you run npm install afterwards?

viankakrisna · 2019-02-09T23:26:44Z

i think npm users can use this workaround https://github.com/rogeriochaves/npm-force-resolutions

…v#941

ajv-validator/ajv#941

* See: ajv-validator/ajv#941 * Trying to get fresh build since upgrading lodash * Check for updates on Monday

TheLarkInn · 2019-02-10T05:09:40Z

Hey @epoberezkin we have reported upstream workaround in our linked issue webpack/webpack#8768 so hopefully this reduces the chatter while this is being tackled by your team or other AJV contributors.

If there is anything we can do to help, let us know. - webpack team

Because ajv@6.9.0 does not work with webpack. Ref: ajv-validator/ajv#941

epoberezkin · 2019-02-10T08:37:41Z

Thanks for the patience, going to fix 7079aed - I think I know what the issue is.

errors can also be "full"...

epoberezkin · 2019-02-10T08:44:32Z

released 6.9.1

cenfun · 2019-02-10T08:54:51Z

released 6.9.1

thanks, just test with ajv@6.9.1 and it works now.

epoberezkin · 2019-02-10T08:57:24Z

Please let me know if somebody is still affected. The validation of custom keyword was simply incorrect, and now it is fixed. But it is still a bit more restrictive than it was - it would only fail though if e.g. somebody used 0 instead of false, which seems unlikely.

epoberezkin · 2019-02-10T09:00:01Z

It probably is possible to make travis CI run tests of some dependencies against the new tags (e.g. webpack and eslint).

csvan · 2019-02-10T10:10:07Z

@epoberezkin thanks for the fix!

epoberezkin · 2019-02-10T10:13:09Z

closing

Lock the version of AJV for now, until issue is resolved webpack/webpack#8768 ajv-validator/ajv#941

tetreault mentioned this issue Feb 9, 2019

Error: custom keyword definition is invalid: data.errors should be boolean #942

Closed

caldempsey changed the title ~~Latest AJV Push causing failure to build node modules in React~~ Latest AJV Push causing failure to build node_modules (multiple dependencies and users affected) Feb 9, 2019

BrianMitchL mentioned this issue Feb 9, 2019

Cannot start new project due to Ajv error facebook/create-react-app#6385

Closed

caldempsey changed the title ~~Latest AJV Push causing failure to build node_modules (multiple dependencies and users affected)~~ NPM: Latest AJV Push causing failure to build node_modules (multiple dependencies and users affected) Feb 9, 2019

caldempsey changed the title ~~NPM: Latest AJV Push causing failure to build node_modules (multiple dependencies and users affected)~~ NPM: Latest AJV Push causing failure to execute node_modules (multiple dependencies and users affected) Feb 9, 2019

dkulchenko mentioned this issue Feb 9, 2019

Boilerplate app newly created by vue-cli fails to start vuejs/vue-cli#3441

Closed

fkleuver added a commit to aurelia/aurelia that referenced this issue Feb 10, 2019

chore(browserstack): pin ajv to 6.8.1 for now due to ajv-validator/aj…

937dd8c

…v#941

supersonicclay added a commit to supersonicclay/grok-groceries that referenced this issue Feb 10, 2019

Downgrade ajv (for now)

4885579

ajv-validator/ajv#941

greyscaled pushed a commit to KevinMarley/KevinMarley.github.io that referenced this issue Feb 10, 2019

Downgrade AJV (temp workaround)

578496c

* See: ajv-validator/ajv#941 * Trying to get fresh build since upgrading lodash * Check for updates on Monday

y-yagi mentioned this issue Feb 10, 2019

Avoid ajv@6.9.0 for now rails/rails#35211

Merged

y-yagi added a commit to y-yagi/rails that referenced this issue Feb 10, 2019

Avoid ajv@6.9.0 for now

7942d67

Because ajv@6.9.0 does not work with webpack. Ref: ajv-validator/ajv#941

epoberezkin mentioned this issue Feb 10, 2019

Add test for custom keyword with option errors: "full" #944

Open

epoberezkin added a commit that referenced this issue Feb 10, 2019

fix: incorrect custom keyword definition schema, #941

fe7f91d

acid-chicken referenced this issue in misskey-dev/misskey Feb 10, 2019

Update package.json

e579b49

epoberezkin added the bug label Feb 10, 2019

epoberezkin mentioned this issue Feb 10, 2019

Run tests of some dependent packages against the new ajv tags #945

Open

FloEdelmann mentioned this issue Feb 10, 2019

Update ajv to version 6.9.1 OpenLightingProject/open-fixture-library#778

Merged

epoberezkin closed this as completed Feb 10, 2019

This was referenced Feb 10, 2019

package:discover fails os-js/osjs-cli#11

Closed

Build fails [node_modules/webpack-cli/bin/cli.js:231] os-js/osjs-ace-application#2

Closed

pieh mentioned this issue Feb 11, 2019

Error: custom keyword definition is invalid: data.errors should be boolean gatsbyjs/gatsby#11678

Closed

jscheffner mentioned this issue Feb 12, 2019

Error when running 'gridsome develop' on newly created project gridsome/gridsome#187

Closed

This was referenced Feb 14, 2019

Use Typescript aurelia/aurelia#425

Merged

Update Typescript and other dev(Dependencies) aurelia/aurelia#440

Merged

johnrackles pushed a commit to johnrackles/react-intersection-observer that referenced this issue Feb 19, 2020

fix: Webpack broken by AJV update

8acd461

Lock the version of AJV for now, until issue is resolved webpack/webpack#8768 ajv-validator/ajv#941

batpad mentioned this issue Mar 2, 2022

downgrade ajv back to 5.5.2, refs #2270 IFRCGo/go-frontend#2271

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPM: 6.9.0 AJV Commit causing failure to execute node_modules (multiple dependencies affected i.e. ESLint and WebPack Loaders) #941

NPM: 6.9.0 AJV Commit causing failure to execute node_modules (multiple dependencies affected i.e. ESLint and WebPack Loaders) #941

caldempsey commented Feb 9, 2019 •

edited

yooouuri commented Feb 9, 2019

caldempsey commented Feb 9, 2019

yooouuri commented Feb 9, 2019

tetreault commented Feb 9, 2019 •

edited

caldempsey commented Feb 9, 2019

yooouuri commented Feb 9, 2019 •

edited

mcrawshaw commented Feb 9, 2019

velocity-360 commented Feb 9, 2019

yooouuri commented Feb 9, 2019

csvan commented Feb 9, 2019 •

edited

velocity-360 commented Feb 9, 2019

yooouuri commented Feb 9, 2019

caldempsey commented Feb 9, 2019 •

edited

richard-karp commented Feb 9, 2019

caldempsey commented Feb 9, 2019 •

edited

viankakrisna commented Feb 9, 2019

viankakrisna commented Feb 9, 2019

richard-karp commented Feb 9, 2019

gregoriB commented Feb 9, 2019 •

edited

andrewtet commented Feb 9, 2019

viankakrisna commented Feb 9, 2019

caldempsey commented Feb 9, 2019 •

edited

gregoriB commented Feb 9, 2019

viankakrisna commented Feb 9, 2019

TheLarkInn commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

cenfun commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

epoberezkin commented Feb 10, 2019 •

edited

csvan commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

NPM: 6.9.0 AJV Commit causing failure to execute node_modules (multiple dependencies affected i.e. ESLint and WebPack Loaders) #941

NPM: 6.9.0 AJV Commit causing failure to execute node_modules (multiple dependencies affected i.e. ESLint and WebPack Loaders) #941

Comments

caldempsey commented Feb 9, 2019 • edited

yooouuri commented Feb 9, 2019

caldempsey commented Feb 9, 2019

yooouuri commented Feb 9, 2019

tetreault commented Feb 9, 2019 • edited

caldempsey commented Feb 9, 2019

yooouuri commented Feb 9, 2019 • edited

mcrawshaw commented Feb 9, 2019

velocity-360 commented Feb 9, 2019

yooouuri commented Feb 9, 2019

csvan commented Feb 9, 2019 • edited

velocity-360 commented Feb 9, 2019

yooouuri commented Feb 9, 2019

caldempsey commented Feb 9, 2019 • edited

richard-karp commented Feb 9, 2019

caldempsey commented Feb 9, 2019 • edited

viankakrisna commented Feb 9, 2019

viankakrisna commented Feb 9, 2019

richard-karp commented Feb 9, 2019

gregoriB commented Feb 9, 2019 • edited

andrewtet commented Feb 9, 2019

viankakrisna commented Feb 9, 2019

caldempsey commented Feb 9, 2019 • edited

gregoriB commented Feb 9, 2019

viankakrisna commented Feb 9, 2019

TheLarkInn commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

cenfun commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

epoberezkin commented Feb 10, 2019 • edited

csvan commented Feb 10, 2019

epoberezkin commented Feb 10, 2019

caldempsey commented Feb 9, 2019 •

edited

tetreault commented Feb 9, 2019 •

edited

yooouuri commented Feb 9, 2019 •

edited

csvan commented Feb 9, 2019 •

edited

caldempsey commented Feb 9, 2019 •

edited

caldempsey commented Feb 9, 2019 •

edited

gregoriB commented Feb 9, 2019 •

edited

caldempsey commented Feb 9, 2019 •

edited

epoberezkin commented Feb 10, 2019 •

edited