Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Cancel threads from a recursive search. #107

Closed
islanddog opened this issue Nov 2, 2020 · 6 comments · Fixed by #121 or #178
Closed

[FEATURE REQUEST] Cancel threads from a recursive search. #107

islanddog opened this issue Nov 2, 2020 · 6 comments · Fixed by #121 or #178
Assignees
Labels
enhancement New feature or request has-PR pinned

Comments

@islanddog
Copy link

Is your feature request related to a problem? Please describe.
Nope; actually I came across this last week and love it.

Describe the solution you'd like
The ability to cut a thread on a scan. So for instance, if I find a hidden CMS solution on a port at /wordpress/ and the scan begins scanning the /wordpress/ directory to stop the scan of the original directory. I get I could cancel or start a new instance but with application searching, you could filter your recursive searching to cut down on time. I guess you could also pipe it into an additional scan?

Describe alternatives you've considered
Cancelling the current scan and starting a new one.

Additional context
None.

@islanddog islanddog added the enhancement New feature or request label Nov 2, 2020
@epi052
Copy link
Owner

epi052 commented Nov 2, 2020

Thanks for the request!

The pause|resume feature added in 1.4.0 is a gateway of sorts into features like this.

The vision was you can pause the scan, and then stop current scans based on some form of input. That's effectively what you're talking about, right?

  1. Pause scan
  2. Stop one or more of the scans currently running
  3. Resume all scans that weren't stopped in step 2

Is that similar to what you had in mind?

@islanddog
Copy link
Author

Yes, that is exactly what I had in mind and I updated to 1.4.0 this morning to test exactly that. Right now it's great for recursive searching but to be able to run a scan and get:

IP Address
     WordPress
       - wp-content [x]
       - wp-includes [x]
       - etc

and then pause the scan to exclude those directories and continue scanning would really optimize the overall process. So in the use case above I know WordPress includes a wp-content and wp-includes directory but I am trying to see if additional folders/files exist without putting it too many requests to the server.

@epi052
Copy link
Owner

epi052 commented Nov 2, 2020

Awesome! That's essentially where I wanted the pause|resume scan thing to eventually go. Thanks for the feature request and thank you for checking out the tool!

@epi052 epi052 self-assigned this Nov 8, 2020
@epi052 epi052 added the blocked label Nov 10, 2020
@epi052
Copy link
Owner

epi052 commented Nov 10, 2020

tokio 0.3 added abort to its JoinHandle struct. I looked at using a few other solutions, but they'd require a pretty significant overhaul to the current structure.

I'd like to wait on the following libraries to upgrade to tokio 0.3 so that feroxbuster can transition to the new version. Using tokio's built-in abort will drastically simplify this feature.

Upgraded yet?

@stale
Copy link

stale bot commented Dec 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 12, 2020
@epi052
Copy link
Owner

epi052 commented Dec 30, 2020

Blockers for this one are all removed, just need to finish up the implementation. This mainly means figuring out how to get input/output from/to the user in a way that doesn't suck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request has-PR pinned
Projects
None yet
2 participants