Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prettier to format *.{ts,json,md,vue} #631

Open
tharvik opened this issue Feb 13, 2024 · 3 comments
Open

use prettier to format *.{ts,json,md,vue} #631

tharvik opened this issue Feb 13, 2024 · 3 comments

Comments

@tharvik
Copy link
Collaborator

tharvik commented Feb 13, 2024

currently, formatting is done using eslint & standard. the first one is a linter actually warning when a line doesn't fit the formatting specs, but doesn't enforce a single representation of a code (one can add empty lines everywhere, or disabling eslint on a line disallow formatting). it's also only for JS/TS, not json, not markdown.

prettier is way better in my opinion, by ensuring that for a given code/AST, it always yield the same output, folding lines as needed, replacing quotes or adding/removing trailing commas automatically. it also works with many filetypes (looking at you vue), and is opiniated so no more bikesheding. it also provide a clear separation between formatting (nice code writing) and linting (bugs lurking), which is confortable.

@JulienVig
Copy link
Collaborator

JulienVig commented Mar 25, 2024

I updated your link so that our mention doesn't appear in their discussion feed.
Edit: it seems it is still in their feed, you may have to delete your comment to remove it.
fyi https://github.com/orgs/community/discussions/23123

@tharvik
Copy link
Collaborator Author

tharvik commented Mar 25, 2024

standard seems to be dying: https://www.github.com/standard/standard/issues/1948

@tharvik
Copy link
Collaborator Author

tharvik commented Mar 25, 2024

I updated your link so that our mention doesn't appear in their discussion feed.

haha, keeping github clean, that's nice

Edit: it seems it is still in their feed, you may have to delete your comment to remove it. fyi https://github.com/orgs/community/discussions/23123

arf, it didn't work..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants