Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Presets saved to local storage appear on canvas after switching Macro/Micro modes #4640

Closed
Zhirnoff opened this issue May 17, 2024 · 2 comments · Fixed by #4666
Closed

Preview: Presets saved to local storage appear on canvas after switching Macro/Micro modes #4640

Zhirnoff opened this issue May 17, 2024 · 2 comments · Fixed by #4666
Assignees
@ilya-asiyuk-epam
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High RNA Builder Bucket: RNA builder related issues
Projects
Ketcher
Milestone
Ketcher 2.22.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macro mode
  2. Add any preset to 'Presets' section using RNA Builder
  3. Switch to Micro mode and back to Macro
  4. The preset is not visible on the canvas, but it is there (if you click Save, you can see in preview that there are monomers on canvas)
  5. Switch any of 'Snake' or 'Sequence' layout modes and presets will appear on canvas

Actual behavior
Presets saved to local storage appear on canvas after switching layout modes

Expected behavior
Presets saved to local storage not appear on canvas after switching layout modes

Screenshots

2024-05-17_13h16_35

2024-05-17_13h25_54.mp4

Desktop (please complete the following information):**

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.1] local master build
@Zhirnoff Zhirnoff added bug Priority: High Macromolecules Macro-Micro Bucket: Macro-Micro View related issues RNA Builder Bucket: RNA builder related issues labels May 17, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.22.0-rc.1 milestone May 17, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this May 17, 2024
@ilya-asiyuk-epam
Copy link
Collaborator

TODO:
simplify/update code from this PR - #4512

ilya-asiyuk-epam added a commit that referenced this issue May 21, 2024
@ilya-asiyuk-epam
#4640 - Preview: Presets saved to local storage appear on canvas afte…
a75f078 
…r switching Macro/Micro modes
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request May 21, 2024 that will close this issue
#4640 - Preview: Presets saved to local storage appear on canvas after switching Macro/Micro modes #4666
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue May 21, 2024
@ilya-asiyuk-epam
#4640 - Preview: Presets saved to local storage appear on canvas afte…
cb7c525 
…r switching Macro/Micro modes
@ilya-asiyuk-epam ilya-asiyuk-epam added this to Code review in Ketcher May 21, 2024
ilya-asiyuk-epam added a commit that referenced this issue May 22, 2024
@ilya-asiyuk-epam
#4640 - Preview: Presets saved to local storage appear on canvas afte…
42de537 
…r switching Macro/Micro modes
ilya-asiyuk-epam added a commit that referenced this issue May 23, 2024
@ilya-asiyuk-epam
Merge pull request #4666 from epam/4640-preview-presets-saved-to-loca…
242004a 
…l-storage-appear-on-canvas-after-switching-macro-micro-modes

#4640 - Preview: Presets saved to local storage appear on canvas after switching Macro/Micro modes
Ketcher automation moved this from Code review to Ready for testing May 23, 2024
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jun 4, 2024

Tested. Bug fixed.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]

@Zhirnoff Zhirnoff moved this from Ready for testing to In testing in Ketcher Jun 4, 2024
@Zhirnoff Zhirnoff moved this from In testing to Done in Ketcher Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High RNA Builder Bucket: RNA builder related issues
Projects
Ketcher
  
Done
Milestone
Ketcher 2.22.0-rc.2
2 participants
@Zhirnoff @ilya-asiyuk-epam