From 81613356ea7e9d38fbbe9a6155025b326c874bbd Mon Sep 17 00:00:00 2001 From: ZhangJian He Date: Mon, 15 Nov 2021 11:32:56 +0800 Subject: [PATCH] Remove unnecessary boxing unboxing (#12790) --- .../java/org/apache/pulsar/tests/FailFastNotifier.java | 2 +- .../pulsar/tests/FastThreadLocalCleanupListener.java | 2 +- .../org/apache/pulsar/tests/MockitoCleanupListener.java | 2 +- .../apache/pulsar/tests/ThreadLeakDetectorListener.java | 4 +--- .../apache/bookkeeper/mledger/impl/ManagedCursorTest.java | 2 +- .../broker/authentication/AuthenticationProviderList.java | 2 +- .../pulsar/broker/admin/impl/PersistentTopicsBase.java | 2 +- .../java/org/apache/pulsar/broker/rest/TopicsBase.java | 2 +- .../transaction/buffer/impl/InMemTransactionBuffer.java | 2 +- .../org/apache/pulsar/broker/admin/TopicPoliciesTest.java | 2 +- .../pulsar/client/impl/auth/AuthenticationAthenz.java | 2 +- .../org/apache/pulsar/common/tls/TlsHostnameVerifier.java | 2 +- .../pulsar/policies/data/loadbalancer/BrokerUsage.java | 4 ++-- .../windowing/triggers/WatermarkCountTriggerPolicy.java | 2 +- .../functions/windowing/WindowFunctionExecutorTest.java | 2 +- .../apache/pulsar/functions/utils/FunctionConfigUtils.java | 2 +- .../pulsar/functions/worker/FunctionMetaDataManager.java | 2 +- .../pulsar/functions/worker/rest/api/ComponentImpl.java | 7 +++---- .../apache/pulsar/io/cassandra/CassandraAbstractSink.java | 2 +- .../decoder/primitive/PulsarPrimitiveRowDecoder.java | 6 +++--- .../apache/pulsar/sql/presto/TestPulsarRecordCursor.java | 2 +- .../sql/presto/decoder/primitive/TestPrimitiveDecoder.java | 2 +- .../java/org/apache/pulsar/websocket/ConsumerHandler.java | 2 +- .../jcloud/provider/TieredStorageConfiguration.java | 4 ++-- 24 files changed, 30 insertions(+), 33 deletions(-) diff --git a/buildtools/src/main/java/org/apache/pulsar/tests/FailFastNotifier.java b/buildtools/src/main/java/org/apache/pulsar/tests/FailFastNotifier.java index 3ee4ad70a76746..0f001332a98d84 100644 --- a/buildtools/src/main/java/org/apache/pulsar/tests/FailFastNotifier.java +++ b/buildtools/src/main/java/org/apache/pulsar/tests/FailFastNotifier.java @@ -41,7 +41,7 @@ */ public class FailFastNotifier implements IInvokedMethodListener, ITestListener { - private static final boolean FAIL_FAST_ENABLED = Boolean.valueOf( + private static final boolean FAIL_FAST_ENABLED = Boolean.parseBoolean( System.getProperty("testFailFast", "true")); static class FailFastEventsSingleton { diff --git a/buildtools/src/main/java/org/apache/pulsar/tests/FastThreadLocalCleanupListener.java b/buildtools/src/main/java/org/apache/pulsar/tests/FastThreadLocalCleanupListener.java index cd75bfbd4318ea..c40956a9e259ea 100644 --- a/buildtools/src/main/java/org/apache/pulsar/tests/FastThreadLocalCleanupListener.java +++ b/buildtools/src/main/java/org/apache/pulsar/tests/FastThreadLocalCleanupListener.java @@ -27,7 +27,7 @@ public class FastThreadLocalCleanupListener extends BetweenTestClassesListenerAdapter { private static final Logger LOG = LoggerFactory.getLogger(FastThreadLocalCleanupListener.class); private static final boolean FAST_THREAD_LOCAL_CLEANUP_ENABLED = - Boolean.valueOf(System.getProperty("testFastThreadLocalCleanup", "true")); + Boolean.parseBoolean(System.getProperty("testFastThreadLocalCleanup", "true")); private static final String FAST_THREAD_LOCAL_CLEANUP_PACKAGE = System.getProperty("testFastThreadLocalCleanupPackage", "org.apache.pulsar"); private static final FastThreadLocalStateCleaner CLEANER = new FastThreadLocalStateCleaner(object -> { diff --git a/buildtools/src/main/java/org/apache/pulsar/tests/MockitoCleanupListener.java b/buildtools/src/main/java/org/apache/pulsar/tests/MockitoCleanupListener.java index 0724a9dc222611..354a55c10e39fa 100644 --- a/buildtools/src/main/java/org/apache/pulsar/tests/MockitoCleanupListener.java +++ b/buildtools/src/main/java/org/apache/pulsar/tests/MockitoCleanupListener.java @@ -32,7 +32,7 @@ public class MockitoCleanupListener extends BetweenTestClassesListenerAdapter { private static final Logger LOG = LoggerFactory.getLogger(MockitoCleanupListener.class); private static final boolean - MOCKITO_CLEANUP_ENABLED = Boolean.valueOf(System.getProperty("testMockitoCleanup", "true")); + MOCKITO_CLEANUP_ENABLED = Boolean.parseBoolean(System.getProperty("testMockitoCleanup", "true")); @Override protected void onBetweenTestClasses(Class endedTestClass, Class startedTestClass) { diff --git a/buildtools/src/main/java/org/apache/pulsar/tests/ThreadLeakDetectorListener.java b/buildtools/src/main/java/org/apache/pulsar/tests/ThreadLeakDetectorListener.java index ddfebc9a44d9e6..163591cf82554d 100644 --- a/buildtools/src/main/java/org/apache/pulsar/tests/ThreadLeakDetectorListener.java +++ b/buildtools/src/main/java/org/apache/pulsar/tests/ThreadLeakDetectorListener.java @@ -32,9 +32,7 @@ */ public class ThreadLeakDetectorListener extends BetweenTestClassesListenerAdapter { private static final Logger LOG = LoggerFactory.getLogger(ThreadLeakDetectorListener.class); - private static final boolean - THREAD_LEAK_DETECTOR_ENABLED = Boolean.valueOf(System.getProperty("testThreadLeakDetector", - "true")); + private Set capturedThreadKeys; @Override diff --git a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java index 4bfcf944c437eb..bbc182719d89eb 100644 --- a/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java +++ b/managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedCursorTest.java @@ -2251,7 +2251,7 @@ public void findEntryFailed(ManagedLedgerException exception, Optional c1.asyncFindNewestMatching(ManagedCursor.FindPositionConstraint.SearchAllAvailableEntries, entry -> { try { - long publishTime = Long.valueOf(new String(entry.getData())); + long publishTime = Long.parseLong(new String(entry.getData())); return publishTime <= timestamp; } catch (Exception e) { log.error("Error de-serializing message for message position find", e); diff --git a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java index a79fabef3deb29..9ec1c2eb706cc3 100644 --- a/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java +++ b/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderList.java @@ -206,7 +206,7 @@ public boolean authenticateHttpRequest(HttpServletRequest request, HttpServletRe } } ); - return authenticated.booleanValue(); + return authenticated; } @Override diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java index fc33ad4ea56731..3944ae8f80ed38 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java @@ -1059,7 +1059,7 @@ protected void internalGetSubscriptions(AsyncResponse asyncResponse, boolean aut existsFutures.put(i, topicResources().persistentTopicExists(topicName.getPartition(i))); } FutureUtil.waitForAll(Lists.newArrayList(existsFutures.values())).thenApply(__ -> - existsFutures.entrySet().stream().filter(e -> e.getValue().join().booleanValue()) + existsFutures.entrySet().stream().filter(e -> e.getValue().join()) .map(item -> topicName.getPartition(item.getKey()).toString()) .collect(Collectors.toList()) ).thenAccept(topics -> { diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/TopicsBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/TopicsBase.java index 8151a82b5c089d..1df2c14bc9c943 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/TopicsBase.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/rest/TopicsBase.java @@ -641,7 +641,7 @@ private List buildMessage(ProducerMessages producerMessages, Schema sch } } if (null != message.getEventTime() && !message.getEventTime().isEmpty()) { - messageMetadata.setEventTime(Long.valueOf(message.getEventTime())); + messageMetadata.setEventTime(Long.parseLong(message.getEventTime())); } if (message.isDisableReplication()) { messageMetadata.clearReplicateTo(); diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBuffer.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBuffer.java index f66b263812da34..98d572cc0827f6 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBuffer.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/InMemTransactionBuffer.java @@ -194,7 +194,7 @@ public TransactionBufferReader newReader(long sequenceId) throws final SortedMap entriesToRead = new TreeMap<>(); synchronized (entries) { - SortedMap subEntries = entries.tailMap(Long.valueOf(sequenceId)); + SortedMap subEntries = entries.tailMap(sequenceId); subEntries.values().forEach(value -> value.retain()); entriesToRead.putAll(subEntries); } diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java index 00ecb0de1f8a92..491157c568a78f 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java @@ -1398,7 +1398,7 @@ public void testRemovePublishRate() throws Exception { @Test public void testCheckMaxConsumers() throws Exception { - Integer maxProducers = new Integer(-1); + Integer maxProducers = -1; log.info("MaxConsumers: {} will set to the topic: {}", maxProducers, testTopic); try { admin.topics().setMaxConsumers(testTopic, maxProducers); diff --git a/pulsar-client-auth-athenz/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.java b/pulsar-client-auth-athenz/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.java index 1e9588a1df1441..447a21ce056453 100644 --- a/pulsar-client-auth-athenz/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.java +++ b/pulsar-client-auth-athenz/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.java @@ -159,7 +159,7 @@ private void setAuthParams(Map authParams) { } this.keyId = authParams.getOrDefault("keyId", "0"); - this.autoPrefetchEnabled = Boolean.valueOf(authParams.getOrDefault("autoPrefetchEnabled", "false")); + this.autoPrefetchEnabled = Boolean.parseBoolean(authParams.getOrDefault("autoPrefetchEnabled", "false")); if (isNotBlank(authParams.get("athenzConfPath"))) { System.setProperty("athenz.athenz_conf", authParams.get("athenzConfPath")); diff --git a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java index 9a2964d123801e..3ab5b5f63f76c6 100644 --- a/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java +++ b/pulsar-common/src/main/java/org/apache/pulsar/common/tls/TlsHostnameVerifier.java @@ -289,7 +289,7 @@ static List getSubjectAltNames(final X509Certificate cert) { if (type != null) { final Object o = entry.get(1); if (o instanceof String) { - result.add(new SubjectName((String) o, type.intValue())); + result.add(new SubjectName((String) o, type)); } else if (o instanceof byte[]) { // TODO ASN.1 DER encoded form } diff --git a/pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/BrokerUsage.java b/pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/BrokerUsage.java index 57915029d6f5aa..6fd7d60fbd9c3e 100644 --- a/pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/BrokerUsage.java +++ b/pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/BrokerUsage.java @@ -56,13 +56,13 @@ public static BrokerUsage populateFrom(Map metrics) { BrokerUsage brokerUsage = null; if (metrics.containsKey("brk_conn_cnt")) { brokerUsage = new BrokerUsage(); - brokerUsage.connectionCount = ((Long) metrics.get("brk_conn_cnt")).longValue(); + brokerUsage.connectionCount = (Long) metrics.get("brk_conn_cnt"); } if (metrics.containsKey("brk_repl_conn_cnt")) { if (brokerUsage == null) { brokerUsage = new BrokerUsage(); } - brokerUsage.replicationConnectionCount = ((Long) metrics.get("brk_repl_conn_cnt")).longValue(); + brokerUsage.replicationConnectionCount = (Long) metrics.get("brk_repl_conn_cnt"); } return brokerUsage; } diff --git a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/triggers/WatermarkCountTriggerPolicy.java b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/triggers/WatermarkCountTriggerPolicy.java index 26a9ce737996e7..7b60e63e45224f 100644 --- a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/triggers/WatermarkCountTriggerPolicy.java +++ b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/windowing/triggers/WatermarkCountTriggerPolicy.java @@ -83,7 +83,7 @@ private void handleWaterMarkEvent(Event waterMarkEvent) { List eventTs = windowManager.getSlidingCountTimestamps(lastProcessedTs, watermarkTs, count); for (long ts : eventTs) { - evictionPolicy.setContext(new DefaultEvictionContext(ts, null, Long.valueOf(count))); + evictionPolicy.setContext(new DefaultEvictionContext(ts, null, (long) count)); handler.onTrigger(); lastProcessedTs = ts; } diff --git a/pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutorTest.java b/pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutorTest.java index 9e0973370603fa..f3502d667b381c 100644 --- a/pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutorTest.java +++ b/pulsar-functions/instance/src/test/java/org/apache/pulsar/functions/windowing/WindowFunctionExecutorTest.java @@ -89,7 +89,7 @@ public long extractTimestamp(Long input) { private static class TestWrongTimestampExtractor implements TimestampExtractor { @Override public long extractTimestamp(String input) { - return Long.valueOf(input); + return Long.parseLong(input); } } diff --git a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java index 539f066a6db10a..9b8d8d4f4ed855 100644 --- a/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java +++ b/pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java @@ -56,7 +56,7 @@ @Slf4j public class FunctionConfigUtils { - static final Integer MAX_PENDING_ASYNC_REQUESTS_DEFAULT = Integer.valueOf(1000); + static final Integer MAX_PENDING_ASYNC_REQUESTS_DEFAULT = 1000; static final Boolean FORWARD_SOURCE_MESSAGE_PROPERTY_DEFAULT = Boolean.TRUE; private static final ObjectMapper OBJECT_MAPPER = ObjectMapperFactory.create(); diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java index 5388bd703312fc..eddb469ba92730 100644 --- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java +++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java @@ -365,7 +365,7 @@ private void processUncompactedMetaDataTopicMessage(Message message) thr } private void processCompactedMetaDataTopicMessage(Message message) throws IOException { - long version = Long.valueOf(message.getProperty(versionTag)); + long version = Long.parseLong(message.getProperty(versionTag)); String tenant = FunctionCommon.extractTenantFromFullyQualifiedName(message.getKey()); String namespace = FunctionCommon.extractNamespaceFromFullyQualifiedName(message.getKey()); String functionName = FunctionCommon.extractNameFromFullyQualifiedName(message.getKey()); diff --git a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java index 44f6c75ed55186..927f51155e54bd 100644 --- a/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java +++ b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java @@ -341,10 +341,9 @@ private void deleteStatestoreTableAsync(String namespace, String table) { StorageAdminClient adminClient = worker().getStateStoreAdminClient(); if (adminClient != null) { adminClient.deleteStream(namespace, table).whenComplete((res, throwable) -> { - if ((throwable == null && res.booleanValue()) - || (throwable != null && - (throwable instanceof NamespaceNotFoundException - || throwable instanceof StreamNotFoundException) )) { + if ((throwable == null && res) + || ((throwable instanceof NamespaceNotFoundException + || throwable instanceof StreamNotFoundException))) { log.info("{}/{} table deleted successfully", namespace, table); } else { if (throwable != null) { diff --git a/pulsar-io/cassandra/src/main/java/org/apache/pulsar/io/cassandra/CassandraAbstractSink.java b/pulsar-io/cassandra/src/main/java/org/apache/pulsar/io/cassandra/CassandraAbstractSink.java index 874710afb48606..4cd31380f0078d 100644 --- a/pulsar-io/cassandra/src/main/java/org/apache/pulsar/io/cassandra/CassandraAbstractSink.java +++ b/pulsar-io/cassandra/src/main/java/org/apache/pulsar/io/cassandra/CassandraAbstractSink.java @@ -98,7 +98,7 @@ private void createClient(String roots) { String[] hostPort = hosts[i].split(":"); b.addContactPoint(hostPort[0]); if (hostPort.length > 1) { - b.withPort(Integer.valueOf(hostPort[1])); + b.withPort(Integer.parseInt(hostPort[1])); } } cluster = b.build(); diff --git a/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/primitive/PulsarPrimitiveRowDecoder.java b/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/primitive/PulsarPrimitiveRowDecoder.java index 5eb2d7f6db6134..bc192c81eb0126 100644 --- a/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/primitive/PulsarPrimitiveRowDecoder.java +++ b/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/primitive/PulsarPrimitiveRowDecoder.java @@ -79,12 +79,12 @@ public Optional> decodeRow(ByteBuf primitiveColumn.put(columnHandle, booleanValueProvider(Boolean.valueOf((Boolean) value))); } else if (type instanceof TinyintType || type instanceof SmallintType || type instanceof IntegerType || type instanceof BigintType) { - primitiveColumn.put(columnHandle, longValueProvider(Long.valueOf(value.toString()))); + primitiveColumn.put(columnHandle, longValueProvider(Long.parseLong(value.toString()))); } else if (type instanceof DoubleType) { - primitiveColumn.put(columnHandle, doubleValueProvider(Double.valueOf(value.toString()))); + primitiveColumn.put(columnHandle, doubleValueProvider(Double.parseDouble(value.toString()))); } else if (type instanceof RealType) { primitiveColumn.put(columnHandle, longValueProvider( - Float.floatToIntBits((Float.valueOf(value.toString()))))); + Float.floatToIntBits((Float.parseFloat(value.toString()))))); } else if (type instanceof VarbinaryType) { primitiveColumn.put(columnHandle, bytesValueProvider((byte[]) value)); } else if (type instanceof VarcharType) { diff --git a/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/TestPulsarRecordCursor.java b/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/TestPulsarRecordCursor.java index 8d521834c6a5c4..610a1c2e695aaf 100644 --- a/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/TestPulsarRecordCursor.java +++ b/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/TestPulsarRecordCursor.java @@ -101,7 +101,7 @@ public void testTopics() throws Exception { assertEquals(pulsarRecordCursor.getSlice(i).getBytes(), ((String) fooFunctions.get("field2").apply(count)).getBytes()); columnsSeen.add(fooColumnHandles.get(i).getName()); } else if (fooColumnHandles.get(i).getName().equals("field3")) { - assertEquals(pulsarRecordCursor.getLong(i), Float.floatToIntBits(((Float) fooFunctions.get("field3").apply(count)).floatValue())); + assertEquals(pulsarRecordCursor.getLong(i), Float.floatToIntBits((Float) fooFunctions.get("field3").apply(count))); columnsSeen.add(fooColumnHandles.get(i).getName()); } else if (fooColumnHandles.get(i).getName().equals("field4")) { assertEquals(pulsarRecordCursor.getDouble(i), ((Double) fooFunctions.get("field4").apply(count)).doubleValue()); diff --git a/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/decoder/primitive/TestPrimitiveDecoder.java b/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/decoder/primitive/TestPrimitiveDecoder.java index f4810ba70d816e..61142a1bfa2db0 100644 --- a/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/decoder/primitive/TestPrimitiveDecoder.java +++ b/pulsar-sql/presto-pulsar/src/test/java/org/apache/pulsar/sql/presto/decoder/primitive/TestPrimitiveDecoder.java @@ -141,7 +141,7 @@ public void testPrimitiveType() { .copiedBuffer(schemaFloat.encode(floatValue))).get(); checkValue(decodedRowFloat, new PulsarColumnHandle(getPulsarConnectorId().toString(), PRIMITIVE_COLUMN_NAME, REAL, false, false, PRIMITIVE_COLUMN_NAME, null, null, - PulsarColumnHandle.HandleKeyValueType.NONE), Long.valueOf(Float.floatToIntBits(floatValue))); + PulsarColumnHandle.HandleKeyValueType.NONE), Float.floatToIntBits(floatValue)); double doubleValue = 0.22d; SchemaInfo schemaInfoDouble = SchemaInfo.builder().type(SchemaType.DOUBLE).build(); diff --git a/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java b/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java index c6d0c8f3f6edc5..7f1d8a7161426a 100644 --- a/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java +++ b/pulsar-websocket/src/main/java/org/apache/pulsar/websocket/ConsumerHandler.java @@ -103,7 +103,7 @@ public ConsumerHandler(WebSocketService service, HttpServletRequest request, Ser this.numMsgsDelivered = new LongAdder(); this.numBytesDelivered = new LongAdder(); this.numMsgsAcked = new LongAdder(); - this.pullMode = Boolean.valueOf(queryParams.get("pullMode")); + this.pullMode = Boolean.parseBoolean(queryParams.get("pullMode")); try { // checkAuth() and getConsumerConfiguration() should be called after assigning a value to this.subscription diff --git a/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfiguration.java b/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfiguration.java index 442980ad336d28..c1054969a42808 100644 --- a/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfiguration.java +++ b/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfiguration.java @@ -244,7 +244,7 @@ public Integer getMaxBlockSizeInBytes() { return Integer.valueOf(configProperties.get(key)); } } - return new Integer(64 * MB); + return 64 * MB; } public Integer getMinBlockSizeInBytes() { @@ -262,7 +262,7 @@ public Integer getReadBufferSizeInBytes() { return Integer.valueOf(configProperties.get(key)); } } - return new Integer(MB); + return MB; } public Integer getWriteBufferSizeInBytes() {