server: add Node to stream closed callbacks #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bing Han <h.bing612@gmail.com>
tony612
force-pushed
the
add-node-to-stream-close-callback
branch
from
3a65643
to
726c071
Compare
|
I didn't change CHANGELOG for the moment. Should I do that by myself? If so, I guess we should use a new Release(v0.10.4)? |
|
@alecholmez Could you help review this PR? |
|
No worry on bumping the changelog I'll have to do that when I cut a new release. |
alecholmez
approved these changes
Jul 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Node to OnStreamClosed and OnDeltaStreamClosed of Callbacks
Fixes #569