Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable HTTPRoute method matching conformance test #659

Closed
skriss opened this issue Oct 28, 2022 · 3 comments · Fixed by #880
Closed

enable HTTPRoute method matching conformance test #659

skriss opened this issue Oct 28, 2022 · 3 comments · Fixed by #880
Assignees
@haq204
Labels
area/ci CI and build related issues area/conformance Gateway API Conformance Related Issues good first issue Good for newcomers
Milestone
0.3.0-rc.1

Comments

@skriss
Copy link
Contributor

skriss commented Oct 28, 2022

Once Gateway API v0.6.0 has been released and picked up here, we should enable the HTTPRoute method matching test, since it's been implemented in #658.

The test is here: https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-method-matching.go

It also requires adding the SupportedFeature to our suite.Options:
@skriss skriss added the area/conformance Gateway API Conformance Related Issues label Oct 28, 2022
@skriss skriss mentioned this issue Oct 29, 2022
Merged
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 28, 2022
@danehans danehans added help wanted Extra attention is needed area/ci CI and build related issues and removed stale labels Dec 1, 2022
@danehans danehans added this to the 0.3.0-rc.1 milestone Dec 1, 2022
@danehans danehans added the good first issue Good for newcomers label Dec 1, 2022
@haq204
Copy link
Contributor

haq204 commented Jan 5, 2023 •
edited

Hi @skriss I would like to pick up this issue for the v0.3.0-rc.1 Milestone if no one currently working on it. It seems like once #853 is merged this should be doable.

@arkodg
Copy link
Contributor

arkodg commented Jan 5, 2023

hey @haq204 go for it !

@arkodg arkodg removed the help wanted Extra attention is needed label Jan 5, 2023
@haq204 haq204 mentioned this issue Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haq204 haq204

Labels
area/ci CI and build related issues area/conformance Gateway API Conformance Related Issues good first issue Good for newcomers
Projects
None yet
Milestone
0.3.0-rc.1
Development

Successfully merging a pull request may close this issue.

Enable HTTPRouteMethodMatching conformance test datawire/envoy-gateway
4 participants
@danehans @skriss @arkodg @haq204