Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction filtering by direction and type #1024

Open
morremeyer opened this issue Apr 27, 2024 · 0 comments
Open

Transaction filtering by direction and type #1024

morremeyer opened this issue Apr 27, 2024 · 0 comments
Labels
bug Something isn't working as supposed to enhancement New feature or improvements to an existing one

Comments

@morremeyer
Copy link
Member

Transaction filtering

The transaction filtering we have in place currently is incomplete and wrong since it tries to enable both filtering by the direction of the transaction, considering if the involved accounts are internal or external as well as the type of the transaction, considering the effects on the buyget.

I thought about this for a while and arrived at the conclusion that we'll need two different filters, one direction filter and one type filter.

direction: purely for internal/external account considerations

Has the following filter values

  • incoming: Transaction from an external to an internal account
  • outgoing: Transaction from an internal account to an external account
  • internal: Transaction from an internal to an internal account

type: For the effect a transaction has on the budget

Has the following filter values

  • income: From an off-budget to an on-budget account
  • spend: From an on-budget to an off-budget account
  • transfer: From an on-budget to an on-budget account

I'm not yet happy with incoming and income being named this similarly. Any suggestions to improve this are very welcome.

@morremeyer morremeyer added bug Something isn't working as supposed to enhancement New feature or improvements to an existing one labels Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as supposed to enhancement New feature or improvements to an existing one
Projects
None yet
Development

No branches or pull requests

1 participant