New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show target instead of module path by default #209
Conversation
I think the main problem is there is nobody actively maintaining this crate. I'm helping with PRs that I consider uncontroversial, but for #205 I have no idea about that / whether it could break some people. The same applies to this PR, I'm afraid.
Yeah, the version should be bumped by a maintainer when doing a release, not ahead of time. |
Yeah, I got that kind of feeling browsing through the commit history... However it's still in heavy use, so I think this is worth the effort.
I can remove the second commit and this shouldn't break compatibility in any way, if you prefer. As far as the public api is concerned it would only add the function I originally included 365ffaf, due to the comments stating willingness to do just that in the linked issues (by @KodrAus), but it would be easy to keep the current default, and opt in to the new behavior until it's convenient/decided to make it the new default: env_logger::builder()
.format_target(true)
.format_module_path(false)
.init(); |
You seem to be dedicated to making this work, which is nice. However, I really don't want to dedicate more than an absolute minimum of my time to maintenance here¹. @sirwindfield if you're still around it would be nice if you could decide whether / how to move forward here. ¹Mainly since I've fully switched to tracing and so am no longer using `env_logger`. |
Context for this is I'd heard of For now I'll just leave this here. If you need me to change anything, ping me. Otherwise, I guess just let it be. But this is a simple change, all things considered. If maintaining the crate is too time-consuming and there is a good alternative, It may be time to consider mentioning that in the readme and/or the docs... |
I'm in the same boat. Uni takes most of my time right now (finals 🥳). I have to take a day to see what exatly changes behaviour-vise in this and other PRs. Sorry for the lack of activity. |
Looking good to me. I'm OK with changing the default behavior. We just need to bump the minor then. |
This is an alternative to #205, since that pr seems to be incomplete/stalled.
Fixes #155
Fixes #179
These changes also likely warrant a minor version bump since they alter the default output format - but I'm leaving it out of the pr since I'm unsure of what the exact roadmap is, if any.