Don't use eprint from logger implementations. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
force-pushed
the
master
branch
3 times, most recently
from
a8d3949
to
8378447
Compare
badboy
reviewed
Nov 13, 2020
eprint! panics on io errors, which might cause unnecessary crashes like https://bugzilla.mozilla.org/show_bug.cgi?id=1676882.
badboy
approved these changes
Nov 18, 2020
jplatte
approved these changes
Nov 18, 2020
|
Thanks! |
|
Thanks @jplatte. |
|
Working on it. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eprint! panics on io errors, which might cause unnecessary crashes like
https://bugzilla.mozilla.org/show_bug.cgi?id=1676882.