Deprecate env_logger::from_env and clean up examples #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
env_logger::builder
andenv_logger::from_env
methods are a bit confusing as-is, because it's not clear thatenv_logger::builder
should callBuilder::from_default_env
instead ofBuilder::new
. Thebuilder
function is a convenient way to get started configuring your logger before initializing it, but thefrom_env
method doesn't actually save you any work because you still need touse env_logger::Env
, so may as welluse env_logger::{Builder, Env}
while you're at it.I've also cleaned up our examples a bit and added a new one for logging in
cargo test
.