Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PySide6-related test skips #555

Open
1 of 3 tasks
mdickinson opened this issue Mar 23, 2023 · 2 comments
Open
1 of 3 tasks

Remove PySide6-related test skips #555

mdickinson opened this issue Mar 23, 2023 · 2 comments

Comments

@mdickinson
Copy link
Member

mdickinson commented Mar 23, 2023

We're currently skipping some tests in our Ubuntu GitHub Actions runs because of a PySide6 bug that triggers an end-of-process segfault. Those test skips should be removed once they're no longer needed. This requires:

  • A PySide 6.4.3 release (already happened)
  • EDM to have PySide 6.4.3 or later
  • Pyface fixes for compatibility with PySide6 6.4.x. (Fixes already made; now waiting on a Pyface release.)

xref: #476
xref: https://bugreports.qt.io/browse/PYSIDE-2254

@mdickinson mdickinson changed the title Remove test skips Remove PySide6-related test skips Mar 23, 2023
@mdickinson
Copy link
Member Author

#528 is related

@mdickinson
Copy link
Member Author

"EDM to have PySide 6.4.3 or later" <- This condition isn't actually strictly required, since the next release of Pyface contains a workaround for the segfaults that should be good enough for us to be able to remove the skips.

So #528 and this issue can likely be solved together as soon as the next Pyface release is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant