Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib.resources to locate test data #439

Open
mdickinson opened this issue Jul 27, 2021 · 1 comment
Open

Use importlib.resources to locate test data #439

mdickinson opened this issue Jul 27, 2021 · 1 comment
Projects
Enthought OSS Q3 2021

Comments

@mdickinson
Copy link
Member

Some of the unit tests are currently using __file__ to locate test data. We should use importlib.resources instead.
@rahulporuri rahulporuri added this to To be considered in Enthought OSS Q3 2021 via automation Jul 27, 2021
@mdickinson
Copy link
Member Author

Currently, using importlib.resources is unpleasant if one also wants to remain compatible with Python versions earlier than 3.9: in Python 3.11, essentially all of the pre-3.9 version of importlib.resources is deprecated. I suggest we close this issue for now. We can revisit to use importlib.resources once Python 3.8 and older are no longer a concern.

We could use pkg_resources in the interim.

@mdickinson mdickinson mentioned this issue Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Enthought OSS Q3 2021
  
To be considered
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdickinson