Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete interface implementations #292

Open
2 tasks
rahulporuri opened this issue Jun 25, 2020 · 2 comments
Open
2 tasks

Incomplete interface implementations #292

rahulporuri opened this issue Jun 25, 2020 · 2 comments

Comments

@rahulporuri
Copy link
Contributor

rahulporuri commented Jun 25, 2020

  • Application is missing registered and unregistered events to fully implement IServiceRegistry
  • WorkbenchWindow is missing registered, unregistered events and the get_service_from_id method to fully implement IServiceRegistry
@rahulporuri
Copy link
Contributor Author

ref pyface error which is causing the failure in our testsuite - enthought/pyface#551

@rahulporuri rahulporuri changed the title Test failures when traits.has_traits.CHECK_INTERFACES is set to 2 Incomplete interface implementations Aug 4, 2020
@rahulporuri
Copy link
Contributor Author

Note to implementer/solver : We need to decide whether or not it is actually worth it to fully implement the interfaces in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant