From 5815ce407aad43fb013dd126543936a0538f9613 Mon Sep 17 00:00:00 2001 From: Huy TQ <5723282+imhuytq@users.noreply.github.com> Date: Fri, 4 Mar 2022 20:50:30 +0700 Subject: [PATCH 1/2] add name to versioned migration files --- dialect/sql/schema/atlas.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dialect/sql/schema/atlas.go b/dialect/sql/schema/atlas.go index 555f411008..23e3cff6de 100644 --- a/dialect/sql/schema/atlas.go +++ b/dialect/sql/schema/atlas.go @@ -364,7 +364,7 @@ func (m *Migrate) atDiff(ctx context.Context, conn dialect.ExecQuerier, tables . return nil, err } // Plan changes. - return drv.PlanChanges(ctx, "", changes) + return drv.PlanChanges(ctx, "changes", changes) } type db struct{ dialect.ExecQuerier } From bb7c9bc285932be0567e533424ddcea71d0b58da Mon Sep 17 00:00:00 2001 From: Huy TQ <5723282+imhuytq@users.noreply.github.com> Date: Fri, 4 Mar 2022 20:54:41 +0700 Subject: [PATCH 2/2] Skip writing migration files if the plan has no changes --- dialect/sql/schema/migrate.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dialect/sql/schema/migrate.go b/dialect/sql/schema/migrate.go index 80c4b25152..04ff0359fd 100644 --- a/dialect/sql/schema/migrate.go +++ b/dialect/sql/schema/migrate.go @@ -171,6 +171,10 @@ func (m *Migrate) Diff(ctx context.Context, tables ...*Table) error { if err != nil { return err } + // Skip if the plan has no changes + if len(plan.Changes) == 0 { + return nil + } return migrate.New(nil, m.atlas.dir, m.atlas.fmt).WritePlan(plan) }