Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialect/sql/schema: ensure consistency of NotCleanError #3310

Merged
merged 2 commits into from Feb 10, 2023

Conversation

blukai
Copy link
Contributor

@blukai blukai commented Feb 9, 2023

@masseelch
Copy link
Collaborator

Thank you @blukai for submitting this PR. Once the Atlas one is merged, can you update the go.mod to point to the latest Atlas master together with this changes?

@blukai
Copy link
Contributor Author

blukai commented Feb 10, 2023

yup, but in a separate pr.
pr ariga/atlas#1454 cannot be merged sooner than this one. atlas depends on ent, ent is returning NotCleanError value (not a pointer) in dialect/sql/schema.

@masseelch
Copy link
Collaborator

yup, but in a separate pr. pr ariga/atlas#1454 cannot be merged sooner than this one. atlas depends on ent, ent is returning NotCleanError value (not a pointer) in dialect/sql/schema.

Ah, got it.

@masseelch masseelch merged commit 349b950 into ent:master Feb 10, 2023
blukai added a commit to blukai/ent that referenced this pull request Feb 13, 2023
a8m pushed a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants