entc/gen: support type-based matching for edge-schema columns #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of no match by foreign-keys, we search by edge-type. This can happen if the type (edge owner) is named T, but the edge-schema E names its edge field as u_id. We consider it as a match if there is only one usage of T in E.
|
Hmm just want to make sure but this looks like it was a response to the repro I created and posted in Discord ~2 weeks ago or so? https://github.com/NickDubelman/ent/tree/edge-schema-repro I'm going to try and pull master and see if it resolves my issue! |
|
Seems to fix it! Thanks a lot for the quick fix, your solution is better than what I expected because it doesn't require any explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of no match by foreign-keys, we search by edge-type. This can happen if the type (edge owner) is named
T, but the edge-schemaEnames its edge field asu_id. We consider it as a match if there is only one usage ofTinE.