Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialect/sql/schema: use serial underlying types for fks #2963

Merged
merged 1 commit into from Sep 27, 2022
Merged

dialect/sql/schema: use serial underlying types for fks #2963

merged 1 commit into from Sep 27, 2022

Conversation

a8m
Copy link
Member

@a8m a8m commented Sep 26, 2022 •
edited

See #2953

giautm
giautm approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@giautm giautm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 💯

masseelch
masseelch approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@masseelch masseelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@a8m a8m merged commit e93e96e into master Sep 27, 2022
@a8m a8m deleted the pgserial branch September 27, 2022 04:54
@timoha timoha mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giautm giautm giautm approved these changes

@masseelch masseelch masseelch approved these changes

@rotemtam rotemtam Awaiting requested review from rotemtam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a8m @giautm @masseelch