From f312edd8ffe479c89f870697d1e6816ec029bae1 Mon Sep 17 00:00:00 2001 From: Jannik Clausen Date: Tue, 27 Sep 2022 13:16:32 +0200 Subject: [PATCH] dialect/sql/schema: disable foreign keys before opening a transaction --- dialect/sql/schema/sqlite.go | 2 +- dialect/sql/schema/sqlite_test.go | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/dialect/sql/schema/sqlite.go b/dialect/sql/schema/sqlite.go index 04f90f017c..6b07fe56c2 100644 --- a/dialect/sql/schema/sqlite.go +++ b/dialect/sql/schema/sqlite.go @@ -44,7 +44,7 @@ func (d *SQLite) Tx(ctx context.Context) (dialect.Tx, error) { if err != nil { return nil, err } - tx := &tx{ExecQuerier: t, Tx: t} + tx := &tx{t} cm, err := sqlite.CommitFunc(ctx, db, tx, true) return &SQLiteTx{Tx: t, commit: cm, rollback: sqlite.RollbackFunc(ctx, db, tx, true)}, nil } diff --git a/dialect/sql/schema/sqlite_test.go b/dialect/sql/schema/sqlite_test.go index 58e6343b6a..433bb8bf99 100644 --- a/dialect/sql/schema/sqlite_test.go +++ b/dialect/sql/schema/sqlite_test.go @@ -467,14 +467,6 @@ func (m sqliteMock) commit() { WillReturnResult(sqlmock.NewResult(0, 1)) } -func (m sqliteMock) rollback() { - m.ExpectQuery("PRAGMA foreign_key_check"). - WillReturnRows(sqlmock.NewRows([]string{})) // empty - m.ExpectRollback() - m.ExpectExec("PRAGMA foreign_keys = on"). - WillReturnResult(sqlmock.NewResult(0, 1)) -} - func (m sqliteMock) tableExists(table string, exists bool) { count := 0 if exists {