Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the engine support #178

Open
tagliala opened this issue Dec 3, 2017 · 2 comments
Open

Drop the engine support #178

tagliala opened this issue Dec 3, 2017 · 2 comments
Assignees
@tagliala
Labels
breaking change

Comments

@tagliala
Copy link
Collaborator

tagliala commented Dec 3, 2017 •
edited

I'm going to drop the engine support, because it is buggy and the implementation is partial.

A proper engine support should

  1. Preserve the engine helper (Putting an engine in a localized block breaks engine routing method #166); and
  2. Should not duplicate :locale in paths (Routing spec for Engine #173).

If there is someone that would contribute to this and submit a PR, please make sure that the aforementioned points are checked
@tagliala tagliala added this to the 6.0.0 milestone Dec 3, 2017
@tagliala tagliala self-assigned this Dec 3, 2017
tagliala added a commit that referenced this issue Dec 3, 2017
@tagliala
Remove localized engine support
dc87e9d 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Feb 5, 2018
@tagliala
Remove localized engine support
469c0a1 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Apr 9, 2018
@tagliala
Remove localized engine support
bd26045 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Apr 10, 2018
@tagliala
Remove localized engine support
a7c5f6c 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Jun 7, 2018
@tagliala
Remove localized engine support
a2ddeb3 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Oct 3, 2018
@tagliala
Remove localized engine support
1f6df00 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Jan 19, 2019
@tagliala
Remove localized engine support
1958db2 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Mar 14, 2019
@tagliala
Remove localized engine support
16f869f 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue May 16, 2019
@tagliala
Remove localized engine support
3d4b6be 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue May 16, 2019
@tagliala
Remove localized engine support
b7ae64f 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
@tagliala tagliala removed this from the 7.0.0 milestone Jul 20, 2019
tagliala added a commit that referenced this issue Dec 26, 2019
@tagliala
Remove localized engine support
da5e300 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Dec 26, 2019
@tagliala
Remove localized engine support
ce9bce2 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Dec 26, 2019
@tagliala
Remove localized engine support
cf8e2ee 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Apr 17, 2020
@tagliala
Remove localized engine support
6c673cb 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
AsgharRaz pushed a commit to AsgharRaz/route_translator that referenced this issue Nov 3, 2020
@tagliala @AsgharRaz
Remove localized engine support
2e057fb 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes enriclluelles#166, fixes enriclluelles#172, fixes enriclluelles#173 and fixes enriclluelles#178
tagliala added a commit that referenced this issue Jan 13, 2021
@tagliala
Remove localized engine support
011d59f 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Jan 13, 2021
@tagliala
Remove localized engine support
f70f6f7 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Jan 16, 2021
@tagliala
Remove localized engine support
dfc9df0 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
tagliala added a commit that referenced this issue Jan 16, 2021
@tagliala
Remove localized engine support
b882cb9 
The current engine implementation is buggy and incomplete.

We are going to drop the whole feature, waiting for a new contributor

Fixes #166, fixes #172, fixes #173 and fixes #178
@aiomaster
Copy link

Wow, we are using the engine mount feature and worked around the first problem successful (see #166 (comment))
I think it is possible to implement this in route_translator.

The second problem (addressed in #173) does not hit us, cause we don't use route_translator inside the mounted engine.
But it looks like there should be a solution.

I am against dropping this feature, cause even in its current state it is usefull for us.
I can help to provide a fix to #166, if the project is interested.

@tagliala
Copy link
Collaborator Author

I can help to provide a fix to #166, if the project is interested.

Thanks!

I will not drop it for the moment. It took 3 years to release the breaking change explained in #171 to fix #87

If you know how to improve the engine support, feel free to submit a PR, it will be very welcomed

@tagliala tagliala mentioned this issue Oct 1, 2022
Closed
@tagliala tagliala mentioned this issue Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tagliala tagliala

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aiomaster @tagliala