Question: Should the client attempt reconnection if the graphql server goes down?

[brettjashford]

should the client attempt to reconnect if the graphql server goes down (current behavior with graphql-ws)?

if i kill my graphql server, the stream closes without any attempt to reconnect. it seems that we would want this catch block to be hit so the retry logic kicks in, but the async iterator completes and the loop exits. seems like a potential bug, but maybe expected behavior?

i'm running in distinct connections mode, but seeing the same behavior in single connection mode.

• thanks 🙏

[enisdenjo]

So what's happening, when the server goes away, is instead of reaching this catch block, the getResults loop exits and we reach this return instead? If so, this feels like a bug - could you additionally hook a console.log in the onMessage option and provide me with its logs?

[brettjashford]

when logging onMessage, i only get next event(s) (if received through the subscription) ex.

{
    "event": "next",
    "data": {
        "data": ...
        }
    }
}

instead of reaching this catch block, the getResults loop exits and we reach this return instead

i assumed that's what was happening, but after tracing through i see it hits this finally where it calls the proceed callbacks and just kinda quits, never hits this catch block or this return. i'm kinda confused tbh, still getting used to async iterators

[enisdenjo]

Could it be this #22? But that one never hits the finally block. 🤔

[brettjashford]

possibly, i'll keep an eye on #23 and retest once it's solved

[enisdenjo]

Hey @brettjashford, #23 seems to happen only in Node environments and the issue might've not even be caused by graphql-sse itself.

I did a few tests in the browser myself, here's what I did:

1. Start a server with graphql-sse
2. Run GraphiQL using this gist
3. Subscribe to any subscription
4. Wait for 1st event emission
5. Kill server
6. The browser reports POST http://localhost:4000/graphql/stream net::ERR_INCOMPLETE_CHUNKED_ENCODING 200 (OK) immediately in the console

Can you confirm whether is the behaviour you're experiencing too?

[enisdenjo]

Should be fixed in latest versions with #28, #27 and 607b468.