Users With Multiple Roles

[adivated]

If you have a user with rights of multiple roles (e.g. 17), the organizations -> members UI page crashes. thx.

[adivated]

affending line(s) (the .map below) in OrganizationUsersTable.tsx:

const rows = paginatedData.map(({ user }) => {
return {
firstName: user.firstName,
lastName: user.lastName,
email: user.email,
role: getRolesFromRights(user.rights)
.map((role) => t(roleNames.filter((roleName) => roleName.value === role)[0].label))
.join(', ')
};
});

[adivated]

more info. The precise condition was that a user had some global roles and organization roles at the same time (e.g. a platform admin as well as an org admin). The roleNames table in organizationRoles.ts only has the org roles in its mappings, hence the bug above. Not sure how common it will be to have a user with this role setup, but it is possible I suppose. It wouldn't be hard to just add the missing roles to the roleNames var.

[adivated]

or a small fix (which omits the main roles but lets the page complete):

.map((role) => t(roleNames.filter((roleName) => roleName.value === role)[0]?.label))

(not elegant and not recommended...)

or to hide (not display) non org roles:

role: getRolesFromRights(user.rights)
.filter((r) => roleNames.find((elem) => elem.value === r))
.map((role) => t(roleNames.filter((roleName) => roleName.value === role)[0].label))
.join(', ')

thx.

[adivated]

This is actually properly part of a larger discussion with Piotr probably, as there are 2 distinct sets/types of roles in Origin, and they are being mixed but also used for different purposes. Best to hold this until that discussion (maybe tomorrow). thx.