Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reënable Windows CI #2243

Open
2 tasks
kriskowal opened this issue Apr 24, 2024 · 0 comments
Open
2 tasks

Reënable Windows CI #2243

kriskowal opened this issue Apr 24, 2024 · 0 comments
Labels
daemon Issues pertaining the the pet dæmon 🐈‍⬛ metamask test

Comments

@kriskowal
Copy link
Member

What is the Problem Being Solved?

In #2240 we dropped Windows CI support. To restore Windows CI support, we would need:

To value Windows support, we would need a product that can only run with node.exe in Windows. We speculate that this would be useful for an Electron app or similar housing around the pet daemon.

@kriskowal kriskowal added enhancement New feature or request test metamask daemon Issues pertaining the the pet dæmon 🐈‍⬛ and removed enhancement New feature or request labels Apr 24, 2024
kriskowal added a commit that referenced this issue Apr 24, 2024
We’ve seen a lot of EPIPE on write failures that are more common on
Windows than Linux/Mac, though they do occur. For that reason along, it
would be good to restore Windows CI when we track that issue down, but
for now, the flakes are too hard to bear and also block us from
upgrading yarn #2222

Tracking revert #2243
kriskowal added a commit that referenced this issue Apr 26, 2024
closes: #2245 
refs: Agoric/agoric-sdk#451
refs: Agoric/ui-kit#105

## Description

Move from Yarn 1 to Yarn 4. Some advantages,

- actively maintained
- [workspace protocol](https://yarnpkg.com/protocol/workspace) (so we
don't have to maintain version numbers in all deps)
- [patch protocol](https://yarnpkg.com/protocol/patch) (so we don't need
patch-package)
- [constraints](https://yarnpkg.com/features/constraints) (e.g. to
enforce layering)
- path to adopt pnpm-style linker (without changing the UI) (see
#1722 )

However this defers workspace protocol until the publishing workflow can
support it.

### Security Considerations

This does a bulk update of `yarn.lock`. It was automated by Yarn 4.

### Scaling Considerations

n/a

### Documentation Considerations

I reviewed `yarn` commands in *.md and I think they're all accurate.

### Testing Considerations

This could interact with the publishing pipeline. @kriskowal may want to
push a draft before we merge. If problems are found, depending on the
severity, we could follow up in a separate PR to land this sooner reduce
merge conflicts.

This was failing on the Windows tests, something about corepack not
taking effect. I don't know whether Windows is officially supported by
Endo. We've since disabled them.
#2243 is the issue restore.


### Compatibility Considerations

Some CLI commands are slightly different. We are adopting it across the
org so we have to adjust sometime.

### Upgrade Considerations

n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
daemon Issues pertaining the the pet dæmon 🐈‍⬛ metamask test
Projects
None yet
Development

No branches or pull requests

1 participant