Send disconnect event on connection lost for wsproto
#996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
seems like the exception check was added in 3cab132#diff-5f163724db1eaba811cc5e4ed55e529af488e351ee52ccfb7c1ad0329a8f0d92R65-R66 and I dont get the rationale given the context, I know it's been a while but do you remember why @almarklein or @tomchristie ? |
|
Fixes #997 |
2 tasks
|
Thank you for the PR @sephioh ! Also, sorry for the long waiting time. |
Kludex
approved these changes
Oct 28, 2022
Kludex
force-pushed
the
uvicorn-wsproto-issue
branch
from
aaff189
to
37cc16c
Compare
Kludex
reviewed
Oct 29, 2022
Kludex
reviewed
Oct 29, 2022
Kludex
changed the title
websocket.disconnect event when client lost connection on wsproto
Kludex
changed the title
websocket.disconnect event when client lost connection on wsprotowebsocket.disconnect event when client loses connection on wsproto
Kludex
changed the title
websocket.disconnect event when client loses connection on wsprotowsproto
Kludex
added a commit
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using uvicorn with wsproto implementation, if clients do not close websocket connections properly, no
excwill be sent toconnection_lost(see code below).As in the current version of uvicorn, this creates two issues:
websocket.disconnectevents;run_asgi(asyncio) task running for each non properly closed connection;In order to reproduce the issue, follow instructions on this repo: https://github.com/sephioh/uvicorn-wsproto-issue
Edit by @Kludex :