Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults ws max_size on server to 16MB #995

Merged
merged 19 commits into from
May 29, 2021

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Mar 9, 2021

replaces #538 as I had an issue with merges....

@phuong
Copy link

phuong commented Mar 25, 2021

Thank you guys. Pls merge this

@JoanFM
Copy link

JoanFM commented Apr 26, 2021

Hello @euri10 ,

Will you be able to solve the conflict?

@euri10 euri10 requested a review from Kludex May 28, 2021 11:50
@euri10
Copy link
Member Author

euri10 commented May 28, 2021

updated to current master, should be an easy review :) I'd prefer to merge this over #1027 since it's adding more tests

@euri10
Copy link
Member Author

euri10 commented May 28, 2021

updated to current master, should be an easy review :)

tests/protocols/test_websocket.py Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@euri10 euri10 linked an issue May 29, 2021 that may be closed by this pull request
@euri10 euri10 merged commit 95b3bcd into encode:master May 29, 2021
@euri10 euri10 mentioned this pull request May 29, 2021
@euri10 euri10 deleted the euri10-websocket_max_message_size branch May 29, 2021 06:10
@euri10 euri10 mentioned this pull request May 31, 2021
3 tasks
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* Defaults ws max_size on server to 16MB

* Renamed test

* Lint

* Lint 2

* Renamed to ws_max_size

* Added test for Config

* Added click option

* Flake8

* Updated docs in deployment

* Updated docs in index

* Added usage note in settings.md

* Test with new test run_server

* MOre scenarios

* Lint

* Update tests/protocols/test_websocket.py

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>

Co-authored-by: Tom Christie <tom@tomchristie.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add websocket max size
6 participants