Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gunicorn worker not running if extras not installed #901

Merged
merged 3 commits into from
May 28, 2021
Merged

Fix gunicorn worker not running if extras not installed #901

merged 3 commits into from
May 28, 2021

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Dec 18, 2020

Fixes #816

@florimondmanca
Copy link
Member

I got hit by this too — getting errors when starting Gunicorn locally when uvloop and/or httptools were not installed. (httptools was particularly bad, since Gunicorn kept spinning up new processes to make up for the startup failure.)

I think switching to "auto" by default for both loop and HTTP parser sounds good. We probably want to keep this for 0.14 though?

@euri10
Copy link
Member Author

euri10 commented Dec 29, 2020

I think switching to "auto" by default for both loop and HTTP parser sounds good. We probably want to keep this for 0.14 though?

yep I think you're the semver god here !

@florimondmanca florimondmanca added this to the 0.14.0 milestone Dec 29, 2020
@euri10 euri10 requested a review from Kludex May 28, 2021 12:34
Kludex
Kludex approved these changes May 28, 2021
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to keep this for 0.14 though?

Yes.

@Kludex Kludex merged commit e3570ce into encode:master May 28, 2021
@euri10 euri10 deleted the 816_good_defaults branch May 28, 2021 17:25
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@euri10 @Kludex
Fix gunicorn worker not running if extras not installed (encode#901)
d7d5f21 
* Change gunicorn worker to use loop and http protocols automatically

* Change gunicorn worker to use loop and http protocols automatically

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

@florimondmanca florimondmanca Awaiting requested review from florimondmanca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

UvicornWorker 'auto' loop and http implementations don't work on Linux without extras installed
3 participants
@euri10 @florimondmanca @Kludex