Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove forced raise_signal calls #2314

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove forced raise_signal calls #2314

wants to merge 4 commits into from
+31 −43

Conversation

kleschenko
Copy link

@kleschenko kleschenko commented Apr 25, 2024 •
edited

Summary

This change removes the raise_signal call which breaks default signal handling for subprocesses.

Closes #2289 (and possibly #2294)

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Sponsor Member

Kludex commented Apr 25, 2024

Well... Then the goal of the previous PR is just ignored...

@kleschenko
Copy link
Author

kleschenko commented Apr 25, 2024 •
edited

@Kludex I've just tested the snippet from the original issue #1579 and it works as expected for me with this change

@Kludex
Copy link
Sponsor Member

Kludex commented Apr 26, 2024

Does this makes sense @maxfischer2781 ?

@maxfischer2781
Copy link
Contributor

maxfischer2781 commented Apr 26, 2024 •
edited

I honestly don't know how the raise_signal is supposed to affect subprocesses in the first place; there is no clear repro for #2289 so I cannot say what is the actual issue.

#2294 should definitely not be fixed by removing the raised signal. Yes, the server properly killing itself will lead to a traceback but if the traceback is undesired then only the traceback should be suppressed, not the proper killing.

@maxfischer2781
Copy link
Contributor

@Kludex I've created #2317 instead to fix the issues I could reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Child Processes Not Terminating with Uvicorn 0.29.0
3 participants
@kleschenko @Kludex @maxfischer2781