Remove unused handle_no_connect on wsproto
#1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
force-pushed
the
wsproto/remove-unused-handle-no-connect
branch
from
5405f61
to
69f979d
Compare
This was referenced Nov 10, 2022
Merged
iudeen
reviewed
Nov 11, 2022
|
I don't understand the question. The RemoteProtocolError is raised on data_received. |
|
What I meant to ask was if we need to handle |
@iudeen - If you're happy with this, then you're welcome to review & accept it. |
|
Thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither
RejectConnectionnorRejectDatahave thereasonfield thathandle_no_connectassumes both have, for that, I'm pretty confident this is never reached.What those lines try to solve, it's already handled on
data_receive.