Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user when reload and workers flag are used together #1731

Merged
merged 2 commits into from Oct 31, 2022
Merged

Warn user when reload and workers flag are used together #1731

merged 2 commits into from Oct 31, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Oct 27, 2022 •
edited

Either this, or RuntimeError will do.

@Kludex Kludex requested a review from a team October 27, 2022 07:18
@Kludex Kludex mentioned this pull request Oct 27, 2022
Merged
13 tasks
@iudeen
Copy link
Contributor

iudeen commented Oct 27, 2022

Since we are ignoring, warning is better IMHO.

tomchristie
tomchristie approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks folks. 🙏🏼

@tomchristie tomchristie merged commit 26cace2 into master Oct 31, 2022
@tomchristie tomchristie deleted the warn/when-workers branch October 31, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @iudeen @tomchristie