Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip upgrade in TestSuite checks #1715

Merged
merged 2 commits into from Oct 19, 2022

Conversation

adnaanbheda
Copy link
Contributor

No description provided.

@adnaanbheda
Copy link
Contributor Author

@Kludex Sorry didn't notice that you had already created a PR, welp, feel free to close this!

@adnaanbheda adnaanbheda marked this pull request as ready for review October 18, 2022 19:42
@Kludex
Copy link
Sponsor Member

Kludex commented Oct 18, 2022

I didn't solve it yet. 馃憖

This PR is also not a solution, because it doesn't work locally.

@adnaanbheda
Copy link
Contributor Author

@Kludex on Windows? I tried it out, seems fine

C:\Windows\System32>python -m pip install -U pip
Requirement already satisfied: pip in c:\users\adnaan\appdata\local\programs\python\python310\lib\site-packages (22.2.2)
Collecting pip
  Using cached pip-22.3-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
  Attempting uninstall: pip
    Found existing installation: pip 22.2.2
    Uninstalling pip-22.2.2:
      Successfully uninstalled pip-22.2.2
Successfully installed pip-22.3

@Kludex
Copy link
Sponsor Member

Kludex commented Oct 18, 2022

./scripts/install

@Kludex
Copy link
Sponsor Member

Kludex commented Oct 18, 2022

Locally you are supposed to run the script above to install the dependencies.

@adnaanbheda
Copy link
Contributor Author

adnaanbheda commented Oct 18, 2022

Let me try, curious, what's the error you're getting ?

EDIT:
Okay, gotcha, python3 -m venv/bin/pip is stupid, okay lemme fix this.

Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adnaanbheda 馃檹

@Kludex
Copy link
Sponsor Member

Kludex commented Oct 19, 2022

What is the difference between "$PIP" and ${PIP}?

@Kludex Kludex merged commit 4502717 into encode:master Oct 19, 2022
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Kludex pushed a commit that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants