Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert log exception traceback in case of invalid HTTP request #1518

Merged
merged 2 commits into from Jun 14, 2022
Merged

Revert log exception traceback in case of invalid HTTP request #1518

merged 2 commits into from Jun 14, 2022

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Jun 13, 2022

Fixes #1296
Since #344 (comment) seems to be fixed (we should close it) there's no reason anymore for having those

@Kludex
Copy link
Sponsor Member

Kludex commented Jun 13, 2022

Do we test this already?

@euri10
Copy link
Member Author

euri10 commented Jun 13, 2022

this just reverts the 2 PR #889 and #886 and they didn't have tests and iirc we dont test that

Kludex
Kludex approved these changes Jun 14, 2022
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant "are those lines covered by tests"?

But anyway, it's not a blocker.

@euri10
Copy link
Member Author

euri10 commented Jun 14, 2022

thanks @Kludex
I'll add tests if time permits, not a huge deal not having them for now

@euri10 euri10 merged commit f4bb5ea into encode:master Jun 14, 2022
@euri10 euri10 deleted the 1296_exception_logs branch June 14, 2022 09:09
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@euri10 @Kludex
Revert log exception traceback in case of invalid HTTP request (encod…
31e69f4 
…e#1518)

* Revert "Log exception traceback in case of invalid HTTP request when using h11 (encode#889)"

This reverts commit 2e17dd9

* Revert "Log exception traceback in case of invalid HTTP request when using httptools (encode#886)"

This reverts commit 305ed0e
Kludex pushed a commit that referenced this pull request Oct 29, 2022
@euri10 @Kludex
Revert log exception traceback in case of invalid HTTP request (#1518)
a824be0 
* Revert "Log exception traceback in case of invalid HTTP request when using h11 (#889)"

This reverts commit 2e17dd9

* Revert "Log exception traceback in case of invalid HTTP request when using httptools (#886)"

This reverts commit 305ed0e
@ZhymabekRoman ZhymabekRoman mentioned this pull request Apr 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle exception when receive request with custom method
2 participants
@euri10 @Kludex