Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn raw_path into bytes on both websockets implementations #1487

Merged
merged 2 commits into from May 16, 2022
Merged

Turn raw_path into bytes on both websockets implementations #1487

merged 2 commits into from May 16, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented May 11, 2022

@Kludex Kludex changed the title Turn raw_path into bytes Turn raw_path into bytes on wsproto_impl May 11, 2022
@Kludex Kludex requested a review from a team May 11, 2022 05:10
@tomchristie
Copy link
Member

Looks like some easy to resolve test failures...

Assertions against raw_path that need updating.

@Kludex Kludex changed the title Turn raw_path into bytes on wsproto_impl Turn raw_path into bytes on both websockets implementations May 11, 2022
@Kludex Kludex requested a review from tomchristie May 11, 2022 16:22
@Kludex
Copy link
Sponsor Member Author

Kludex commented May 11, 2022

Looks like some easy to resolve test failures...

Assertions against raw_path that need updating.

Right. The other implementation had the same issue. 👍

@Kludex Kludex added this to the Version 0.18.0 milestone May 11, 2022
@Kludex Kludex self-assigned this May 11, 2022
@Kludex Kludex requested a review from abersheeran May 15, 2022 17:16
@Kludex Kludex merged commit 1a56da9 into master May 16, 2022
@Kludex Kludex deleted the turn-raw-path-into-bytes branch May 16, 2022 04:47
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@Kludex
Turn raw_path into bytes on both websockets implementations (encode…
626b9da 
…#1487)

* Turn `raw_path` into bytes

* fix tests
Kludex added a commit that referenced this pull request Oct 29, 2022
@Kludex
Turn raw_path into bytes on both websockets implementations (#1487)
db7d391 
* Turn `raw_path` into bytes

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abersheeran abersheeran abersheeran approved these changes

@tomchristie tomchristie Awaiting requested review from tomchristie

Assignees

@Kludex Kludex

Labels
websockets
Projects
None yet
Milestone
Version 0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kludex @tomchristie @abersheeran