Send HTTP 400 response for invalid request #1352
Conversation
Given an invalid request, respond with an HTTP 400 error instead of closing the connection without a response.
|
Yes, would be possible. What would be the preferred datatype? |
| from uvicorn.protocols.websockets.auto import AutoWebSocketsProtocol | ||
|
|
||
| if AutoWebSocketsProtocol is None: | ||
| msg = "No supported WebSocket library detected. Please use 'pip install uvicorn[standard]', or install 'websockets' or 'wsproto' manually." # noqa: E501 | ||
| self.logger.warning(msg) |
There was a problem hiding this comment.
This looks like it needs to be deleted.
There was a problem hiding this comment.
this was part of improving user experience in #926 @tomchristie
Do you want we get rid of it ?
There was a problem hiding this comment.
Perhaps it just needs to stay within the if upgrade_value != b"websocket" or self.ws_protocol_class is None: block. It doesn't make sense for this to be within send_400_response right? (Eg. it shouldn't log if it's called because of except httptools.HttpParserError as exc:)
There was a problem hiding this comment.
ha yes you're right I didn't notice if was sent also in that case, I misread thinking it was just for the upgrade case
| from uvicorn.protocols.websockets.auto import AutoWebSocketsProtocol | ||
|
|
||
| if AutoWebSocketsProtocol is None: | ||
| msg = "No supported WebSocket library detected. Please use 'pip install uvicorn[standard]', or install 'websockets' or 'wsproto' manually." # noqa: E501 | ||
| self.logger.warning(msg) |
There was a problem hiding this comment.
This looks like it needs to be deleted.
* Send HTTP 400 response for invalid request Given an invalid request, respond with an HTTP 400 error instead of closing the connection without a response. * changed signature of send_400_response to msg as str Co-authored-by: Mark Breedlove <mb@dp.la>
Given an invalid request, respond with an HTTP 400 error instead of
closing the connection without a response.
Please find here a rebased version of #205