Fix wsproto version check expression #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
force-pushed
the
fix/wsproto-assert-versio
branch
from
b9bf864
to
cf528a8
Compare
tomchristie
reviewed
Jan 28, 2022
Comment on lines
17
to
19
| assert version.parse(wsproto.__version__) > version.parse( | ||
| "0.13" | ||
| ), "Need wsproto version 0.13" |
There was a problem hiding this comment.
I guess you probably mean >= here?
Also the "Need wsproto version 0.13" probably ought to be "Need wsproto version >= 0.13".
Suggested change
| assert version.parse(wsproto.__version__) > version.parse( | |
| "0.13" | |
| ), "Need wsproto version 0.13" | |
| assert version.parse(wsproto.__version__) >= version.parse( | |
| "0.13" | |
| ), "Need wsproto version >= 0.13" |
There was a problem hiding this comment.
To be honest, I just wanted to compare the version right, but yeah, I can also fix it hahaha
Fix applied. I also took the opportunity to improve a little the message. What do you think?
tomchristie
approved these changes
Jan 28, 2022
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* Fix wsproto version check expression * Update wsproto_impl.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.