Enable read of uvicorn settings from environment variables #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2021
Merged
|
@euri10 ping |
euri10
approved these changes
Dec 6, 2021
|
Very nice, thanks a lot! |
Kludex
added a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #693
This is a further implementation proposed by #696. The solution proposed there only enabled
uvicornto read environment variables in case it was run usingpython -m uvicorninstead of the usualuvicornentry point. This PR solves that issue.Here we go further and add a test that loads one of the many settings options, and check that it's used successfully by
uvicorn, and also shows a priority between CLI arguments and environment variables i.e. CLI arguments always have priority in case environment variables are present.Do we have alternatives for this?
Yes. Gunicorn uses a single environment variable called
GUNICORN_CMD_ARGS, instead of using a prefix. See more about it here.Copied from #1114