Override default asyncio event loop with reload only #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euri10
requested changes
Nov 23, 2021
euri10
approved these changes
Nov 24, 2021
This was referenced Feb 15, 2022
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
…de#1257) * Override default asyncio loop with reload only * shortened warning * Added type hints for keyword arguments * Changed to explicit reload keyword argument for loop setups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#535 changed the default event loop in windows to the selector event loop to avoid an issue with the --reload flag (see #529).
This can cause the issue described in #1220 as well as make the asyncio.subprocess.create_subprocess_* calls fail.
This PR overrides the event loop only with reload configured on windows and logs a warning as suggested in this comment.