Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing page to the docs (#1197) #1224

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

humrochagf
Copy link
Contributor

@humrochagf humrochagf commented Oct 20, 2021

A small change to the testing script was added to follow the same testing capabilities from other encode projects, like the ability to run a single testing file or test during development.

EDIT by @Kludex : Closes #1197

@humrochagf
Copy link
Contributor Author

Just the releasing part that I'm not quite sure it's 100% accurate

Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @humrochagf ! 🎉

docs/contributing.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
@humrochagf
Copy link
Contributor Author

Is there anything missing for this one?

Copy link
Member

@euri10 euri10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I let @Kludex push the final go !

Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @humrochagf ! 😄

@Kludex Kludex merged commit 0dcfc02 into encode:master Nov 23, 2021
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* Add contributing page to the docs (encode#1197)

* Applying suggestions to contributing page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Contribution docs page
3 participants