Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use asyncio.run for gunicorn worker #1150

Merged
merged 3 commits into from Aug 13, 2021
Merged

use asyncio.run for gunicorn worker #1150

merged 3 commits into from Aug 13, 2021

Conversation

graingert
Copy link
Member

for some reason this didn't trigger the deprecation warnings in py3.10

@graingert graingert requested a review from Kludex August 13, 2021 12:33
@graingert
Copy link
Member Author

I used github . aka codespaces but they didn't sign my commit

uvicorn/workers.py Outdated Show resolved Hide resolved
uvicorn/workers.py Outdated Show resolved Hide resolved
@Kludex
Copy link
Sponsor Member

Kludex commented Aug 13, 2021

for some reason this didn't trigger the deprecation warnings in py3.10

You mean in the pipeline? We don't have tests for the gunicorn worker, so it's normal.

@Kludex Kludex merged commit aead4c3 into master Aug 13, 2021
@Kludex Kludex deleted the gunicorn-run branch August 13, 2021 16:48
Kludex pushed a commit that referenced this pull request Nov 17, 2021
* use asyncio.run for gunicorn worker

* Update uvicorn/workers.py

* Update uvicorn/workers.py
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* use asyncio.run for gunicorn worker

* Update uvicorn/workers.py

* Update uvicorn/workers.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants